Skip to content

feat(loader): migrate CDC to Flink 2.2 on Java 17 - #47

Closed
imbajin wants to merge 6 commits into
masterfrom
java17-flink-final
Closed

imbajin wants to merge 6 commits into
masterfrom
java17-flink-final

Conversation

@imbajin

@imbajin imbajin commented Oct 3, 2026 •

Copy link
Copy Markdown

No description provided.

@coderabbitai

This comment was marked as outdated.

@chatgpt-codex-connector

This comment was marked as duplicate.

@github-actions github-actions Bot added the loader label Oct 4, 2026
@imbajin
imbajin force-pushed the java17-flink-final branch 2 times, most recently from 6a295de to 07b2219 Compare October 4, 2026 08:22

@bitflicker64 bitflicker64 left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Blocking: yes. Score: 6/10. Summary: The Flink 2.2 Sink V2 migration, the CDC 3.6 package moves and the new null and identity handling look correct, and the packaged MySQL/Flink acceptance passes for a vertex mapping. The new edge update and delete logic has no test that runs in CI. Evidence: read the full diff against java17-candidate-cutover and the surrounding builder code; checked the packaged-cdc-recovery log at this head (HugeGraphDeserializationTest 5, HugeGraphSinkTest 12 and FlinkSinkSerializationTest 1 tests passed, the class-loading probe and verify.py --run passed); ran node --test on flink-launcher.test.cjs (1 pass), bash -n on the launcher, and mvn dependency:list -DincludeScope=runtime for hugegraph-loader at the base and at this head.

Comment thread hugegraph-loader/pom.xml Resolved
imbajin

This comment was marked as resolved.

imbajin

This comment was marked as resolved.

@chatgpt-codex-connector

Copy link
Copy Markdown

You have reached your Codex usage limits for code reviews. You can see your limits in the Codex usage dashboard.
To continue using code reviews, add credits to your account and enable them for code reviews in your settings.

5 similar comments
@chatgpt-codex-connector

Copy link
Copy Markdown

You have reached your Codex usage limits for code reviews. You can see your limits in the Codex usage dashboard.
To continue using code reviews, add credits to your account and enable them for code reviews in your settings.

@chatgpt-codex-connector

Copy link
Copy Markdown

You have reached your Codex usage limits for code reviews. You can see your limits in the Codex usage dashboard.
To continue using code reviews, add credits to your account and enable them for code reviews in your settings.

@chatgpt-codex-connector

Copy link
Copy Markdown

You have reached your Codex usage limits for code reviews. You can see your limits in the Codex usage dashboard.
To continue using code reviews, add credits to your account and enable them for code reviews in your settings.

@chatgpt-codex-connector

Copy link
Copy Markdown

You have reached your Codex usage limits for code reviews. You can see your limits in the Codex usage dashboard.
To continue using code reviews, add credits to your account and enable them for code reviews in your settings.

@chatgpt-codex-connector

Copy link
Copy Markdown

You have reached your Codex usage limits for code reviews. You can see your limits in the Codex usage dashboard.
To continue using code reviews, add credits to your account and enable them for code reviews in your settings.

@github-actions github-actions Bot added the client label Oct 6, 2026
@chatgpt-codex-connector

Copy link
Copy Markdown

You have reached your Codex usage limits for code reviews. You can see your limits in the Codex usage dashboard.
To continue using code reviews, add credits to your account and enable them for code reviews in your settings.

@github-actions github-actions Bot added the hubble label Oct 6, 2026
@chatgpt-codex-connector

Copy link
Copy Markdown

You have reached your Codex usage limits for code reviews. You can see your limits in the Codex usage dashboard.
To continue using code reviews, add credits to your account and enable them for code reviews in your settings.

@chatgpt-codex-connector chatgpt-codex-connector Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: 496ce8b61e

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

- adapt CDC loading to Sink V2 on Java 17
- preserve same-identity updates and reject identity changes
- retain packaged recovery and class-loading validation
- include Flink runtime packaging and license inventory
@imbajin
imbajin force-pushed the java17-flink-final branch from 20f016d to 193843a Compare October 8, 2026 12:14
- recover stale event bases using the current PR merge
- verify canonical branch, merge parents and source head
- preserve native stack checks and final gate freshness
- cover ordinary snapshots and rejected stale inputs
@imbajin
imbajin changed the base branch from java17-candidate-cutover to master October 8, 2026 15:47
- check missing shared options through the Spark launcher
- remove the replaced legacy CDC parser assertion
- verify native Flink exit status propagation
coderabbitai[bot]

This comment was marked as off-topic.

@imbajin

This comment was marked as outdated.

@hugegraph hugegraph deleted a comment from chatgpt-codex-connector Bot Oct 9, 2026
@hugegraph hugegraph deleted a comment from chatgpt-codex-connector Bot Oct 9, 2026
@hugegraph hugegraph deleted a comment from codecov Bot Oct 9, 2026
@imbajin imbajin closed this Oct 10, 2026
@imbajin
imbajin deleted the java17-flink-final branch October 10, 2026 10:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants