Repository navigation
Conversation
- convert JDBC DATETIME through driver timestamps - decode Parquet logical date and timestamp units - preserve unrelated primitive and TIME values - cover native date precision and negative epochs
Codex Review SummaryThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info
Walkthrough本次改动调整 JDBC 对 ChangesLoader 日期时间处理
Priority: ➖ Normal Estimated code review effort: 3 (Moderate) | ~20 minutes Change: Bug fix Merge Risk: ⚪ Minimal · up to No actionable merge-blocking issue is identified; the change is mergeable after normal checks. Pre-merge checks |
|
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: dfecd23e9d
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #53 +/- ##
============================================
+ Coverage 46.62% 46.70% +0.07%
- Complexity 4447 4461 +14
============================================
Files 602 602
Lines 29235 29263 +28
Branches 3422 3426 +4
============================================
+ Hits 13630 13666 +36
+ Misses 14329 14318 -11
- Partials 1276 1279 +3 ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
- parse the fixture through Loader input sources - normalize the existing MySQL vendor contract - query a connection-owned temporal table - retain native date and precision assertions
- avoid the failing Docker Hub authentication endpoint - retain the exact previously successful official image - preserve service settings and all regression assertions
- fetch existing Maven and Java images from official ECR - keep Flink probe and runtime on the same verified image - preserve the distinct Loader and CDC MySQL versions - retain SDK builder overrides and all test assertions
|
You have reached your Codex usage limits for code reviews. You can see your limits in the Codex usage dashboard. |
- Restore original Docker Hub references in CI and Docker builds - Restore original Flink and MySQL verification image tags - Preserve the branch-specific functional fixes and runtime tests
- Pass configured file timezone into Parquet conversion - Interpret DATE and local timestamps in the source zone - Preserve UTC epochs and legacy INT96 behavior - Cover differing JVM zones and accepted timezone aliases
- drain asynchronous tasks before reporting failures - preserve suppressed errors and interrupt state - retain backup input when restore fails - cover corrupt input and valid empty backups
- use configured graph space in existing schema APIs - preserve legacy routes for empty graph spaces - retain request and HTTP error semantics - cover route escaping and request bodies with race
The ordinary Loader distribution cannot start existing GRAPH or Parquet sources: its selected protobuf runtime lacks the PD discovery classes, and Parquet classes are inherited only through Spark's provided dependencies. The ordinary package now carries the dependencies these existing readers require.
- Incorporate the merged Toolchain runtime and launcher fixes - Preserve JDBC, Protobuf and Parquet suite registrations - Retain configured source timezone conversion and regressions
Purpose of the PR
Restore native JDBC DATETIME and Parquet logical date/timestamp conversion. MySQL returns LocalDateTime for DATETIME, while Parquet DATE/TIMESTAMP values were treated as ordinary integers; supported DATE mappings failed or produced incorrect dates.
Found in the Toolchain integration report.
Main Changes
time_zone, including accepted aliases, while UTC timestamps retain their epoch.Verifying these changes
Does this PR potentially affect the following parts?
Documentation Status
Doc - TODODoc - DoneDoc - No Need: corrects existing DATE mappings without adding types or configuration.The ordinary Loader runtime dependency support is already in upstream master through the merged runtime fix. The JDBC conversion itself is independent. The native date fixture uses matching Loader/Server GMT+8 under the existing date serialization contract.
INT96 retains the existing JVM-default timezone interpretation; the configured source timezone applies to DATE and local logical TIMESTAMP. All date and upstream runtime suite registrations are retained after syncing master.