Repository navigation
Conversation
- quote installation, library and classpath paths - pass user arguments unchanged to the Java process - exercise spaces, empty values and globs in both shells - run the ordinary launcher regression in Loader CI
Codex Review SummaryThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
|
Warning Review limit reachedYou've used all free OSS reviews for now. Wait for the free limit to reset to keep reviewing this public repository. Next included review available in 11 minutes. View limit details
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## master #55 +/- ##
============================================
- Coverage 46.62% 44.26% -2.36%
+ Complexity 4447 3260 -1187
============================================
Files 602 377 -225
Lines 29235 22289 -6946
Branches 3422 2974 -448
============================================
- Hits 13630 9866 -3764
+ Misses 14329 11360 -2969
+ Partials 1276 1063 -213 ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
- avoid the failing Docker Hub authentication endpoint - retain the exact previously successful official image - preserve service settings and all regression assertions
- fetch existing Maven and Java images from official ECR - keep Flink probe and runtime on the same verified image - preserve the distinct Loader and CDC MySQL versions - retain SDK builder overrides and all test assertions
|
You have reached your Codex usage limits for code reviews. You can see your limits in the Codex usage dashboard. |
- Restore original Docker Hub references in CI and Docker builds - Restore original Flink and MySQL verification image tags - Preserve the branch-specific functional fixes and runtime tests
Upstream delivery: ASF PR800 uses the same branch and has passed core CI. This duplicate organization PR is superseded under the small-change delivery workflow.
Purpose of the PR
The ordinary Loader launcher splits installation paths and user arguments containing spaces, expands literal globs, and drops empty arguments. The Java process now receives the intended classpath and original argument boundaries.
Reported during master integration testing.
Main Changes
"$@"while preserving existing JVM option handling and classpath order.Verifying these changes
python3 hugegraph-loader/src/test/python/test_loader_launcher.pyand the existing Spark launcher tests pass.Does this PR potentially affect the following parts?
Documentation Status
Doc - TODODoc - DoneDoc - No Need