Skip to content

fix(loader): preserve launcher arguments - #55

Closed
imbajin wants to merge 4 commits into
masterfrom
fix/integration-loader-launcher
Closed

imbajin wants to merge 4 commits into
masterfrom
fix/integration-loader-launcher

Conversation

@imbajin

@imbajin imbajin commented Oct 9, 2026 •

Copy link
Copy Markdown

Upstream delivery: ASF PR800 uses the same branch and has passed core CI. This duplicate organization PR is superseded under the small-change delivery workflow.

Purpose of the PR

The ordinary Loader launcher splits installation paths and user arguments containing spaces, expands literal globs, and drops empty arguments. The Java process now receives the intended classpath and original argument boundaries.

Reported during master integration testing.

loader launcher: before and after

Main Changes

  • Quote installation and library paths, and pass the classpath as one Java argument.
  • Forward user arguments with "$@" while preserving existing JVM option handling and classpath order.
  • Run ordinary launcher argument regressions alongside the Spark launcher checks in Loader CI.

Verifying these changes

  • Trivial rework / code cleanup without any test coverage. (No Need)
  • Already covered by existing tests.
  • Need tests and can be verified as follows:
    • python3 hugegraph-loader/src/test/python/test_loader_launcher.py and the existing Spark launcher tests pass.
    • The original script fails argument regressions; a Java 17 entry point confirms spaces, empty arguments, and literal globs under both Bash and POSIX sh.
    • The native distribution imports legal rows and preserves the expected process behavior against a real Server. Organization and upstream core CI pass.

Does this PR potentially affect the following parts?

  • Nope
  • Dependencies (add/update license info)
  • Modify configurations
  • The public API
  • Other affects: ordinary Loader process arguments

Documentation Status

  • Doc - TODO
  • Doc - Done
  • Doc - No Need

- quote installation, library and classpath paths
- pass user arguments unchanged to the Java process
- exercise spaces, empty values and globs in both shells
- run the ordinary launcher regression in Loader CI
@chatgpt-codex-connector

chatgpt-codex-connector Bot commented Oct 9, 2026 •

Copy link
Copy Markdown

Codex Review Summary

This comment shows the latest Codex review activity on this pull request.

Review Status Commit Review trigger
📝 Code Review ✅ Completed 2026-10-09T21:16:46.425816Z 762e029 PR opened
ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review" or "@codex security review".

Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings.

@github-actions github-actions Bot added the loader label Oct 9, 2026
@coderabbitai

coderabbitai Bot commented Oct 9, 2026 •

Copy link
Copy Markdown

Warning

Review limit reached

You've used all free OSS reviews for now. Wait for the free limit to reset to keep reviewing this public repository.

Next included review available in 11 minutes.

Check out review usage here.

View limit details

Limit details: You’ve used the included review currently available.

Learn how review limits work.

Review configuration:

⚙️ Run configuration
  • Configuration used: Organization UI
  • Review profile: CHILL
  • Plan: Advanced
  • Run ID: 44cf8a9e-1315-47c9-a664-1129dd024063

📥 Commits

Reviewing files that changed from the base of the PR and between e669922 and 8ba764d.


📒 Files selected for processing (3)
  • .github/workflows/loader-ci.yml
  • hugegraph-loader/assembly/static/bin/hugegraph-loader.sh
  • hugegraph-loader/src/test/python/test_loader_launcher.py

  • Autofix · Keep fixing CodeRabbit findings and required CI, and resolving merge conflicts

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

@codecov

codecov Bot commented Oct 9, 2026 •

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 44.26%. Comparing base (e669922) to head (8ba764d).

Additional details and impacted files
@@             Coverage Diff              @@
##             master      #55      +/-   ##
============================================
- Coverage     46.62%   44.26%   -2.36%     
+ Complexity     4447     3260    -1187     
============================================
  Files           602      377     -225     
  Lines         29235    22289    -6946     
  Branches       3422     2974     -448     
============================================
- Hits          13630     9866    -3764     
+ Misses        14329    11360    -2969     
+ Partials       1276     1063     -213     

☔ View full report in Codecov by Harness.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

- avoid the failing Docker Hub authentication endpoint
- retain the exact previously successful official image
- preserve service settings and all regression assertions
- fetch existing Maven and Java images from official ECR
- keep Flink probe and runtime on the same verified image
- preserve the distinct Loader and CDC MySQL versions
- retain SDK builder overrides and all test assertions
@chatgpt-codex-connector

Copy link
Copy Markdown

You have reached your Codex usage limits for code reviews. You can see your limits in the Codex usage dashboard.
To continue using code reviews, add credits to your account and enable them for code reviews in your settings.

- Restore original Docker Hub references in CI and Docker builds
- Restore original Flink and MySQL verification image tags
- Preserve the branch-specific functional fixes and runtime tests
@github-actions github-actions Bot removed the hubble label Oct 10, 2026
@imbajin imbajin closed this Oct 10, 2026
@imbajin
imbajin deleted the fix/integration-loader-launcher branch October 10, 2026 08:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant