Skip to content

fix(go): route schema requests by graph space - #52

Closed
imbajin wants to merge 1 commit into
masterfrom
fix/integration-go-schema
Closed

imbajin wants to merge 1 commit into
masterfrom
fix/integration-go-schema

Conversation

@imbajin

@imbajin imbajin commented Oct 9, 2026 •

Copy link
Copy Markdown

Purpose of the PR

The Go client accepted GraphSpace configuration for vertex/Gremlin requests but ignored it in schema requests. Existing schema operations now route to the configured space; an empty space retains the legacy path.

Found in the Toolchain integration report.

go schema: before and after

Main Changes

  • Apply the existing GraphSpace route prefix to schema, property key, vertex label and edge label operations.
  • Preserve request methods, bodies, query parameters and HTTP error semantics.
  • Add actual HTTP request regressions for empty/default/custom spaces and path escaping. No missing APIs are implemented.

Verifying these changes

  • Trivial rework / code cleanup without any test coverage. (No Need)
  • Already covered by existing tests.
  • Need tests and can be verified as follows:
    • go test -race -count=1 -timeout 30s ./api/v1/... -run '^TestSchemaGraphSpaceRoutes$' -v passes.
    • The same request matrix rejects the original nonempty-space routes while preserving its empty-space behavior.
    • Three independent read-only reviews passed.
    • Authenticated private-space validation exercises every repaired schema method, rejects anonymous access, and independently checks that same-name DEFAULT schema is unchanged. Organization core CI passes.

Does this PR potentially affect the following parts?

  • Nope
  • Dependencies
  • Modify configurations
  • The public API
  • Other affects

Documentation Status

  • Doc - TODO
  • Doc - Done
  • Doc - No Need: fixes the behavior of the existing GraphSpace configuration.

- use configured graph space in existing schema APIs
- preserve legacy routes for empty graph spaces
- retain request and HTTP error semantics
- cover route escaping and request bodies with race
@coderabbitai

coderabbitai Bot commented Oct 9, 2026

Copy link
Copy Markdown

Warning

Review limit reached

You've used all free OSS reviews for now. Wait for the free limit to reset to keep reviewing this public repository.

Next included review available in 59 minutes.

Check out review usage here.

View limit details

Limit details: You’ve used the included review currently available.

Learn how review limits work.

Review configuration:

⚙️ Run configuration
  • Configuration used: Organization UI
  • Review profile: CHILL
  • Plan: Advanced
  • Run ID: 57b111c3-7229-48ea-aee1-8647eda65901

📥 Commits

Reviewing files that changed from the base of the PR and between e669922 and 8884143.


📒 Files selected for processing (5)
  • hugegraph-client-go/api/v1/edgelabel/edgelabel.go
  • hugegraph-client-go/api/v1/propertykey/propertykey.go
  • hugegraph-client-go/api/v1/schema.go
  • hugegraph-client-go/api/v1/schema_graphspace_test.go
  • hugegraph-client-go/api/v1/vertexlabel/vertexlabel.go


  • Autofix · Keep fixing CodeRabbit findings and required CI, and resolving merge conflicts

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

@github-actions github-actions Bot added the client label Oct 9, 2026
@chatgpt-codex-connector

chatgpt-codex-connector Bot commented Oct 9, 2026 •

Copy link
Copy Markdown

Codex Review Summary

This comment shows the latest Codex review activity on this pull request.

Review Status Commit Review trigger
📝 Code Review ✅ Completed 2026-10-09T20:22:23.782837Z 8884143 PR opened
ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review" or "@codex security review".

Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant