Repository navigation
ComputePacboyPackages: keep the rule for pyTooling's extra 'pypi' - #329
Merged
Merged
Conversation
…ide 'dependencies'. pyTooling renamed the extra 'pypi' to 'dependencies' in v10.0.0-rc9, which isn't released yet; rc8 and older only have 'pypi'. Without the rule, '@r9' would stop installing 'python-aiohttp' from pacman for a 'pyTooling[pypi]' requirement on MSYS2 as soon as #328 is released. Co-Authored-By: Patrick Lehmann <Paebbels@gmail.com>
Merged
Up to standards ✅🟢 Issues
|
| Metric | Results |
|---|---|
| Complexity | 0 |
| Duplication | 0 |
NEW Get contextual insights on your PRs based on Codacy's metrics, along with PR and Jira context, without leaving GitHub. Enable AI reviewer
TIP This summary will be updated as you push new changes.
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
GitHub Pipeline
ComputePacboyPackages(and its copytests/pacman_packages.py): pyTooling's extrapypimaps topython-aiohttp:pagain, besidedependencies. ComputePacboyPackages: pyTooling's extras 'dependencies' and 'idna', no sphinx_reports rule #328 replaced the rule, because pyTooling renames the extra todependencies(Extra 'pypi' is named 'dependencies' pyTooling#635) - but that rename ships with pyTooling v10.0.0-rc9, which isn't released; v10.0.0-rc8 and older only havepypi. Released without this rule,@r9would install nopython-aiohttpfrom pacman for apyTooling[pypi]requirement on MSYS2, and pip would try to build aiohttp from source. With it, the release carrying ComputePacboyPackages: pyTooling's extras 'dependencies' and 'idna', no sphinx_reports rule #328 changes nothing for existing consumers.Related Issues and Pull-Requests
pypiany more (in this workspace, pyTooling.Sphinx still does, without MSYS2 jobs).