Repository navigation
Conversation
As pyTooling's own pipeline will; exercises 'publish_sdist' (#319). 'PublishOnPyPI.yml@dev' knows the input now. Co-Authored-By: Patrick Lehmann <Paebbels@gmail.com>
9 f-strings had no placeholder, so their 'f' prefix did nothing; 'f"…"' becomes '"…"', escaped braces '{{'/'}}'
become '{'/'}'. Every string keeps its value. Fixed with CheckNeedlessFStrings (pyflakes F541).
Co-Authored-By: Patrick Lehmann <Paebbels@gmail.com>
An 'if:' is an expression anyway; the house style from pyTooling #588
writes a multi-line condition as a '>-' block scalar without the braces.
8 conditions: 7 in CompletePipeline.yml, 1 in Pipeline.yml. Each
condition's text (yaml.safe_load) equals the old one without '${{' and
'}}'; the more-indented '&&'/'||' lines are unchanged.
Co-Authored-By: Patrick Lehmann <Paebbels@gmail.com>
… docstr-coverage. pyTooling.Sphinx' `report:doc-coverage` directive reads the package's source code with `pyEDAA.Reports.DocumentationCoverage.Python.Analyzer`; docstr-coverage isn't involved. Co-Authored-By: Patrick Lehmann <Paebbels@gmail.com>
Co-Authored-By: Patrick Lehmann <Paebbels@gmail.com>
pyTooling v10 renames its extra 'pypi' (aiohttp, packaging, requests) to 'dependencies', without an alias. The pacboy rewrite rule for 'pyTooling[...]' follows: 'dependencies' maps to 'python-aiohttp:p', the 'pypi' rule is removed. * ComputePacboyPackages/action.yml and its copy tests/pacman_packages.py: rule renamed, sorted into place. * _Checking_Parameters.yml: the fixture requirement and the expected package's comment name the new extra. Simulated the action's script with 'pyTooling[yaml,dependencies,sphinx]': 'python-aiohttp:p' is found through the new rule. Co-Authored-By: Patrick Lehmann <Paebbels@gmail.com>
…' requirement pyTooling gains the extra 'idna' (URL.Parse reads IRIs with iri=True, the host converted by IDNA 2008 via the PyPI package 'idna'), and its unit tests require 'idna >= 3.20'. Both map to the MSYS2 package 'python-idna' (3.20 in mingw64, ucrt64, clang64 and clangarm64). idna is pure Python and would install from PyPI too. MSYS2 ships it, and 'python-aiohttp' (the 'pypi' extra) already installs it through 'python-yarl', so with the mapping pacman owns it whichever way it is asked for. * .github/actions/ComputePacboyPackages/action.yml: 'idna' in 'packages' and in 'subPackages["pytooling"]'. * tests/pacman_packages.py: the same two entries in the standalone copy. Co-Authored-By: Patrick Lehmann <Paebbels@gmail.com>
sphinx_reports is replaced by pyTooling.Sphinx; no repository requires it anymore. Its rewrite rule goes, and so does its line in the requirements fixture of 'Requirements_Check' - the expected pacboy packages lose python-coverage, python-pyaml and python-types-pyyaml, which only it contributed. Checked by running the action's script on the fixture: computed and expected sets are equal. The rule for 'pyedaa.osvvm' still listed sphinx_reports' packages (coverage, markupsafe, pyaml, types-pyyaml) and lacked jsonschema. pyEDAA.OSVVM requires ruamel.yaml, pyVHDLModel and pyEDAA.Reports (lxml, jsonschema): python-jsonschema, python-lxml and the two ruamel.yaml packages. Co-Authored-By: Patrick Lehmann <Paebbels@gmail.com>
…-jsonschema'. pyTooling's extra 'tracing' installs jsonschema for reading OTLP/JSON traces. jsonschema needs 'rpds-py', a Rust extension with no PyPI wheel for MSYS2, so the extra is rewritten to MSYS2's prebuilt package, as the requirement 'jsonschema' already is. Co-Authored-By: Patrick Lehmann <Paebbels@gmail.com>
…no sphinx_reports rule (#328)
Up to standards ✅🟢 Issues
|
| Metric | Results |
|---|---|
| Complexity | 0 |
| Duplication | 0 |
NEW Get contextual insights on your PRs based on Codacy's metrics, along with PR and Jira context, without leaving GitHub. Enable AI reviewer
TIP This summary will be updated as you push new changes.
…ide 'dependencies'. pyTooling renamed the extra 'pypi' to 'dependencies' in v10.0.0-rc9, which isn't released yet; rc8 and older only have 'pypi'. Without the rule, '@r9' would stop installing 'python-aiohttp' from pacman for a 'pyTooling[pypi]' requirement on MSYS2 as soon as #328 is released. Co-Authored-By: Patrick Lehmann <Paebbels@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Note
A patch release on
@r9without new inputs:ComputePacboyPackagesfollows pyTooling v10's extras (dependencies,idna,tracing) and drops the sphinx-reports rule, the multi-lineif:conditions ofCompletePipeline.ymlare written without${{ }}, the job template check ofPublishOnPyPIpublishes no source distribution, and the documentation names the analyzer behind its coverage page.🔧 Changes
ComputePacboyPackages, the pip → MSYS2 package table (ComputePacboyPackages: pyTooling's extras 'dependencies' and 'idna', no sphinx_reports rule #328):pypitodependencies(Extra 'pypi' is named 'dependencies' pyTooling#635):pyTooling[dependencies]maps topython-aiohttp:p, likepyTooling[pypi], whose rule stays for pyTooling up to v10.0.0-rc8 (ComputePacboyPackages: keep the rule for pyTooling's extra 'pypi' #329).idnaandtracingmap topython-idna:pandpython-jsonschema:p, the requirementidnatopython-idna:p.sphinx_reportsis removed: pyTooling.Sphinx replaced sphinx-reports. The rule forpyedaa.osvvmlistspython-jsonschema:p, which pyEDAA.OSVVM needs through pyEDAA.Reports, instead of sphinx-reports' packages.📖 Documentation
doc/DocCoverage.rst: the documentation coverage is analyzed bypyEDAA.Reports.DocumentationCoverage.Python.Analyzerand visualized by pyTooling.Sphinx. The page named docstr-coverage, which thereport:doc-coveragedirective doesn't use. TheCheckDocumentationjob template, which runs the docstr-coverage CLI, is unchanged (Documentation coverage page names pyEDAA.Reports' analyzer #325).🧪 Unit Tests
_Checking_JobTemplates.yml: thePublishOnPyPIdry run setspublish_sdist: 'false', as pyTooling's own pipeline does. The dry run checks the wheel withtwine checkand skips the step checking the source package (Checking: the PublishOnPyPI dry run publishes no source distribution #321).⚙️ GitHub Pipeline
Pipeline.yml: the multi-line condition of theReferencesjob is written without${{ }}(Multi-line 'if:' conditions without '${{ }}' #324).Others
CompletePipeline.yml: the 7 multi-lineif:conditions - both artifact clean-ups, the PDF documentation, the GitHub Pages publication, tagging, the release page and the PyPI publication - are written without${{ }}. Anif:is an expression anyway; each condition's text equals the old one without${{and}}, so the jobs run under the same conditions as before. Single-line conditions are untouched (Multi-line 'if:' conditions without '${{ }}' #324).doc/conf.py,tests/pacman_packages.pyandtests/python_jobs.py: 9 f-strings without placeholder are plain strings; every string keeps its value (f-strings without placeholder are plain strings #323).9.3.1inmyPackage/__init__.pyandmyFramework/Extension/__init__.py.Related Issues and Pull-Requests
PublishOnPyPIdry run publishes no source distribution (follow-up of Package/PublishOnPyPI: choose source distribution and wheel separately #319).if:conditions without${{ }}.ComputePacboyPackagesfollows pyTooling v10's extras; no sphinx-reports rule.pypistays besidedependencies.pyedaa.reportswithout ruamel.yaml packages on MSYS2).