Skip to content

Multi-line 'if:' conditions without '${{ }}' - #324

Merged
Paebbels merged 1 commit into
devfrom
claude/if-without-braces
Oct 20, 2026
Merged

Paebbels merged 1 commit into
devfrom
claude/if-without-braces

Conversation

@pytooling-claude

Copy link
Copy Markdown

An if: is an expression anyway, so a multi-line condition doesn't need the ${{ }} around it. pyTooling #588 established the house style; this PR applies it to the 8 multi-line conditions of the reusable workflows here:

if: >- !failure() && !cancelled() && contains(inputs.documentation_steps, 'pages')

GitHub Pipeline

  • .github/workflows/CompletePipeline.yml: 7 conditions (the two artifact clean-ups, the PDF documentation, the GitHub Pages publication, tagging, the release and the PyPI publication).
  • .github/workflows/Pipeline.yml: the condition of the References job.
  • Only the braces go: each condition's text as YAML parses it (yaml.safe_load) equals the old text without ${{ and }}. The more-indented && / || lines stay as they were, so their line breaks are kept as before. A leading ! inside a >- block scalar is text, not a YAML tag.
  • Single-line if: conditions are untouched.

Related Issues and Pull-Requests

  • Asked in the review of pyTooling #588 (house style of multi-line if:).

An 'if:' is an expression anyway; the house style from pyTooling #588
writes a multi-line condition as a '>-' block scalar without the braces.
8 conditions: 7 in CompletePipeline.yml, 1 in Pipeline.yml. Each
condition's text (yaml.safe_load) equals the old one without '${{' and
'}}'; the more-indented '&&'/'||' lines are unchanged.

Co-Authored-By: Patrick Lehmann <Paebbels@gmail.com>
@pytooling-claude
pytooling-claude Bot requested a review from Paebbels as a code owner October 20, 2026 00:01
@codacy-production

codacy-production Bot commented Oct 20, 2026 •

Copy link
Copy Markdown

Up to standards ✅

🟢 Issues 0 issues

Results:
0 new issues

View in Codacy

🟢 Coverage ∅ diff coverage · +0.00% coverage variation

Metric Results
Coverage variation ✅ +0.00% coverage variation (-1.00%)
Diff coverage ✅ ∅ diff coverage

View coverage diff in Codacy

Coverage variation details
Coverable lines Covered lines Coverage
Common ancestor commit (d283f62) 41 38 92.68%
Head commit (9a281de) 41 (+0) 38 (+0) 92.68% (+0.00%)

Coverage variation is the difference between the coverage for the head and common ancestor commits of the pull request branch: <coverage of head commit> - <coverage of common ancestor commit>

Diff coverage details
Coverable lines Covered lines Diff coverage
Pull request (#324) 0 0 ∅ (not applicable)

Diff coverage is the percentage of lines that are covered by tests out of the coverable lines that the pull request added or modified: <covered lines added or modified>/<coverable lines added or modified> * 100%

NEW Get contextual insights on your PRs based on Codacy's metrics, along with PR and Jira context, without leaving GitHub. Enable AI reviewer
TIP This summary will be updated as you push new changes.

@codecov

codecov Bot commented Oct 20, 2026 •

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 85.36%. Comparing base (d283f62) to head (9a281de).
✅ All tests successful. No failed tests found.

Additional details and impacted files
@@           Coverage Diff           @@
##              dev     #324   +/-   ##
=======================================
  Coverage   85.36%   85.36%           
=======================================
  Files           1        1           
  Lines          41       41           
  Branches        7        7           
=======================================
  Hits           35       35           
  Misses          3        3           
  Partials        3        3           
Flag Coverage Δ
unittests 85.36% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Harness.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@Paebbels
Paebbels merged commit f70eb72 into dev Oct 20, 2026
182 of 185 checks passed
@Paebbels
Paebbels deleted the claude/if-without-braces branch October 20, 2026 06:30
This was referenced Oct 25, 2026

This branch had an error being deployed

1 failed deployment
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants