Repository navigation
docs(dm): fix stale event-filter and binlog-schema examples (#22020) - #22021
ti-chi-bot[bot] merged 4 commits into
Conversation
ti-chi-bot
added
area/dm
contribution
|
No actionable comments were generated in the recent review.
 |
| Layer / File(s) | Summary |
|---|---|
SQL and DDL filter guidance filter-binlog-event.md, migrate-small-mysql-shards-to-tidb.md |
The docs state that DM skips specified procedure statements, explain when a global rule can filter partition-related ALTER TABLE statements, and warn about regex matches. The DDL filter example no longer lists delete; it retains truncate table and drop table. |
Binlog-schema command example migrate-with-more-columns-downstream.md |
The example uses positional database, table, and schema-file arguments instead of -d and -t. It changes the example table and schema filenames to messages and log.messages.sql. |
Priority:
Estimated code review effort: 2 (Simple) | ~10 minutes
Change: Other
Possibly related PRs
- pingcap/docs-cn#22020: This master-branch change updates the same three files with the same documentation changes.
Suggested reviewers: qiancai
Merge Risk: 
e3db5
-
The documentation updates are ready to merge with no identified correctness or operational risk.
Pre-merge checks: 
-
Check name Status Explanation Title check The title clearly summarizes the documentation fixes for event filtering and binlog-schema examples. Description check The description covers the required changes, affected versions, related references, AI involvement, and repository checklist items. It is complete and relevant. Docstring Coverage No eligible functions found in the changed files. Skipping docstring coverage check. Docstring coverage is scoped to functions touched by this diff with cyclomatic complexity of at least 2. Documentat… Linked Issues check Check skipped because no linked issues were found for this pull request. Out of Scope Changes check Check skipped because no linked issues were found for this pull request. Full details: Docstring Coverage
-
Explanation
No eligible functions found in the changed files. Skipping docstring coverage check. Docstring coverage is scoped to functions touched by this diff with cyclomatic complexity of at least 2. Documentation-only edits and deletions within surviving functions are included; unchanged diff context and fully deleted functions are excluded. Analyzed 0 functions across 0 files. (3 skipped: 3 unsupported.)
-
Finishing Touches
-
🧪 Generate unit tests (beta)
-
- Create a new PR
-
- Autofix · Keep fixing CodeRabbit findings and required CI, and resolving merge conflicts
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.
A rabbit reads the filters twice,
Then checks the partition advice.
The schema names line up just right,
The command hops into the night.
Three pages rest beneath the moon,
While carrots wait for review soon.
Comment @coderabbitai help to get the list of available commands.
![coderabbitai[bot]](https://avatars.githubusercontent.com/in/347564?s=60&v=4){kind=small}
|
/approve |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: qiancai The full list of commands accepted by this bot can be found here. The pull request process is described here DetailsNeeds approval from an approver in each of these files:
Approvers can indicate their approval by writing |
This is an automated cherry-pick of #22020
What is changed, added or deleted? (Required)
deleteDML event.binlog-schema updateexample to match the current positional-argument syntax.Which TiDB version(s) do your changes apply to? (Required)
What is the related PR or file link(s)?
AI agent involvement
Do your changes match any of the following descriptions?
Summary by CodeRabbit
TRUNCATE TABLEandDROP TABLEas ignored events.binlog-schema updateexample to use positional arguments and updated its table and schema file names.