Repository navigation
docs(dm): fix stale event-filter and binlog-schema examples - #22020
Conversation
|
Note Reviews pausedIt looks like this branch is under active development. To avoid overwhelming you with review comments due to an influx of new commits, CodeRabbit has automatically paused this review. You can configure this behavior by changing the Use the following commands to manage reviews:
Use the checkboxes below for quick actions:
Walkthrough
Merge Risk:
|
eade597 to
7c93b79
Compare
There was a problem hiding this comment.
Actionable comments posted: 1

Review info
-
Run configuration-
- Source mode: Auto
- Repository: pingcap/docs-cn
- Branch: master
- File: .coderabbit.yaml
- Commit: 9f466f0
- Layers: Repository YAML
- Review profile: ASSERTIVE
- Plan: Advanced
- Run ID:
f4f73127-18ef-4191-9266-b66b7fa71f2f
Files selected for processing: 3-
filter-binlog-event.mdmigrate-small-mysql-shards-to-tidb.mdmigrate-with-more-columns-downstream.md
Included review availability: This review used your included allowance. Your plan provides up to 4 included reviews per hour; 3 remain after this review.
-
|
“dm/dm-manage-schema.md" is not included in this PR because it is already correct and up to date as pingcap/docs#24598 |
There was a problem hiding this comment.
Caution
Some comments are outside the diff and can’t be posted inline due to GitHub limitations.

Minor · 同步存储过程过滤说明。 · filter-binlog-event.md:101
filter-binlog-event.md:101
Minor · Functional Correctness · Quick win 同步存储过程过滤说明。
filter-binlog-event.md说明无需为CREATE PROCEDURE、DROP PROCEDURE和ALTER PROCEDURE配置过滤规则,但dm/dm-binlog-event-filter.md仍建议过滤CREATE PROCEDURE和DROP PROCEDURE,且未覆盖ALTER PROCEDURE。请删除或改写dm/dm-binlog-event-filter.md中的旧示例;如果两个文档面向不同版本,请明确版本范围。

Review info
-
Run configuration-
- Source mode: Auto
- Repository: pingcap/docs-cn
- Branch: master
- File: .coderabbit.yaml
- Commit: 9f466f0
- Layers: Repository YAML
- Review profile: ASSERTIVE
- Plan: Advanced
- Run ID:
dc423390-49b0-4fba-984b-a1628a2a14c6
Files selected for processing: 1-
filter-binlog-event.md
Included review availability: This review used your included allowance. Your plan provides up to 4 included reviews per hour; 2 remain after this review.
-
[LGTM Timeline notifier]Timeline:
|
|
/approve |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: qiancai The full list of commands accepted by this bot can be found here. The pull request process is described here DetailsNeeds approval from an approver in each of these files:
Approvers can indicate their approval by writing |
|
In response to a cherrypick label: new pull request created to branch |
|
In response to a cherrypick label: new pull request created to branch |
What is changed, added or deleted? (Required)
deleteDML event.binlog-schema updateexample to match the current positional-argument syntax.Which TiDB version(s) do your changes apply to? (Required)
What is the related PR or file link(s)?
AI agent involvement
Do your changes match any of the following descriptions?
Summary by CodeRabbit
CREATE PROCEDURE、DROP PROCEDURE和ALTER PROCEDURE;DM 与 TiDB 均支持的分区操作无需配置过滤规则。对于导致解析错误且无需同步的分区语句,可配置全局忽略规则,并注意谨慎使用。delete事件,仍忽略truncate table和drop table。binlog-schema update示例,改用位置参数传入数据库名、表名和 schema 文件。