Repository navigation
Package Foretravel RV-C integration for SetupHelper - #1
Merged
Merged
Conversation
jfishfl
marked this pull request as ready for review
August 11, 2026 13:47
|
Bugbot is not enabled for your account, so this pull request was not reviewed. Enable Bugbot in the Cursor dashboard to get automatic reviews on future PRs. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What changed
0.5.0-rc4application source matched against the live Cerbo deployment.rvforefishpackage with a managedforetravel-rvcrunit service./data/rvforefish-data, outside the GitHub-managed package./data/apps/foretravel-rvcservice and provides an explicit non-destructive legacy configuration import tool.Why
The current coach integration is manually deployed under
/data/apps, so upgrades and Venus OS reinstalls are not managed through the existing SetupHelper/PackageManager workflow. This package makes versioning, controlled updates, reinstall, and rollback visible without coupling GitHub updates to live safety settings.Safety impact
This pull request changes only the repository. It does not install or activate the package on the Cerbo. Migration remains attended, and the legacy deployment stays available as the rollback target.
Validation
./tools/validate-package.sh: 144 tests passed locally.victron.pySHA-256 matched on both sides./tmpstage: package layout, shell syntax, and fail-closed configuration validation passed under the Cerbo runtime. Venus OS omits Python'sunittestmodule, so replay/unit tests remain a development/CI check.git diff --check: passed.Deliberately not included
config.jsonand control gates.