Skip to content

Package Foretravel RV-C integration for SetupHelper - #1

Merged
jfishfl merged 2 commits into
mainfrom
agent/setuphelper-package
Aug 11, 2026
Merged

jfishfl merged 2 commits into
mainfrom
agent/setuphelper-package

Conversation

@jfishfl

@jfishfl jfishfl commented Aug 11, 2026

Copy link
Copy Markdown
Owner

What changed

  • Imported the exact 0.5.0-rc4 application source matched against the live Cerbo deployment.
  • Added the full 144-test replay and unit suite plus its two recorded CAN fixtures.
  • Added a SetupHelper-compatible rvforefish package with a managed foretravel-rvc runit service.
  • Stores operational configuration and generator ownership state under /data/rvforefish-data, outside the GitHub-managed package.
  • Ships a fail-closed default: monitor-only, no RV-C transmission, no control features, no source-label writes, and no automatic current-limit changes.
  • Refuses to overwrite the existing manual /data/apps/foretravel-rvc service and provides an explicit non-destructive legacy configuration import tool.
  • Restricts this initial candidate to the tested Venus OS v3.75 baseline.
  • Adds GitHub Actions validation on Python 3.10 and 3.12.

Why

The current coach integration is manually deployed under /data/apps, so upgrades and Venus OS reinstalls are not managed through the existing SetupHelper/PackageManager workflow. This package makes versioning, controlled updates, reinstall, and rollback visible without coupling GitHub updates to live safety settings.

Safety impact

This pull request changes only the repository. It does not install or activate the package on the Cerbo. Migration remains attended, and the legacy deployment stays available as the rollback target.

Validation

  • ./tools/validate-package.sh: 144 tests passed locally.
  • Exact source comparison against the live Cerbo copy: no differences; victron.py SHA-256 matched on both sides.
  • On-device /tmp stage: package layout, shell syntax, and fail-closed configuration validation passed under the Cerbo runtime. Venus OS omits Python's unittest module, so replay/unit tests remain a development/CI check.
  • git diff --check: passed.
  • Public-tree credential scan: no passwords, tokens, SSH keys, Tailscale domains, private hostnames, or local user paths found.

Deliberately not included

  • Live config.json and control gates.
  • Runtime logs, runit supervision state, Python caches, backups, or release archives.
  • Automatic migration or activation of the live Cerbo service.

@jfishfl
jfishfl marked this pull request as ready for review August 11, 2026 13:47
@cursor

cursor Bot commented Aug 11, 2026

Copy link
Copy Markdown

Bugbot is not enabled for your account, so this pull request was not reviewed.

Enable Bugbot in the Cursor dashboard to get automatic reviews on future PRs.

@jfishfl
jfishfl merged commit f282dc1 into main Aug 11, 2026
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant