Skip to content

majestic-af: bump to 2431ae2 (no clicks, no stops, the right crest, a refocus after day/night) - #2883

Merged
widgetii merged 1 commit into
masterfrom
majestic-af-bump-2431ae2
Nov 17, 2026
Merged

widgetii merged 1 commit into
masterfrom
majestic-af-bump-2431ae2

Conversation

@widgetii

Copy link
Copy Markdown
Member

Bumps majestic-af to OpenIPC/majestic-af#55 (2431ae2) for the HI3516D_N81820 speed dome of #2385.

What changes on a camera (MS41908M lens backend and the af3 search):

  • Continuous drive. Each step burst now fills its 75 ms period (AN41908A app note, p. 17) instead of a full-rate start-stop 13 times a second, which clicked and lost steps going FAR.
  • No homing when nothing moved. With ptz.lensHome, the lens's rest position is kept in /etc/majestic-af.lens. A start, or a WebUI save, no longer homes it into its stops. It homes only with no record, or after a move that was cut short.
  • Stops are kept clear.
    • No move comes within 100 microsteps of the home stop.
    • An axis with no origin moves toward its home stop only.
    • Homing seeks only a margin past a saved position.
  • The right crest. A weak narrow crest no longer ends an autofocus search. At x1 a second subject stopped passes 240 microsteps from focus.
  • Refocus after day/night. The plugin answers autofocus daynight by booking a pass once exposure has settled. It needs a majestic that sends it; an older majestic never does.

Evidence. Run on the lab HI3516D_N81820 dome with that plugin binary, under tools/clickguard, which listens through a second camera's microphone and stops the test on the first click. No click was heard in any of these:

  • Full-speed moves into every limit.
  • A restart with no homing.
  • Autofocus at x1 by day and at ISO ~3100, from both ends of the focus travel, landing at 378–381.
  • /night/on in the dark refocused a defocused lens to 380 by itself.

The builder profile for that dome follows separately with the measured lens travel. The current 3000/3320 are longer than the lens.

@qodo-free-for-open-source-projects

Copy link
Copy Markdown

PR Summary by Qodo

Bump majestic-af for safer lens motion and day/night refocus

✨ Enhancement 🕐 20-40 Minutes

Grey Divider

AI Description

• Pin majestic-af to 2431ae2, bringing upstream lens-motion and autofocus fixes into camera builds.
• The new plugin avoids unnecessary homing, keeps clear of stops, and refocuses after supported
 day/night events.
Diagram

graph TD
  Recipe["Pinned Package"] --> Plugin["AF Plugin"] --> Motor["MS41908M Driver"] --> Lens["Zoom Focus Lens"]
  Majestic["Majestic Runtime"] --> Plugin
  Plugin --> State["Lens State File"]
Loading
High-Level Assessment

Retain the full-SHA pin: it makes shipped plugin versions reproducible without duplicating upstream motor logic locally. Confirm that the target majestic emits day/night events; this bump alone cannot add that support, and the dome's measured travel belongs in its separate builder-profile change.

Files changed (1) +1 / -1

Other (1) +1 / -1
majestic-af.mkPin majestic-af to upstream commit 2431ae2 +1/-1

Pin majestic-af to upstream commit 2431ae2

• Replaces the previous full-SHA source pin with 2431ae2. Builds will pick up upstream motion, homing, autofocus-crest, and day/night refocus behavior; none of that implementation is changed in this repository.

general/package/majestic-af/majestic-af.mk

@qodo-free-for-open-source-projects

Copy link
Copy Markdown

Code Review by Qodo

🐞 Bugs (0) 📘 Rule violations (0) 📎 Requirement gaps (0)

Grey Divider

Great, no issues found!

Qodo reviewed your code and found no material issues that require review

Grey Divider

Tip of the day
💡 Did you know, you can enable the Remediation agent and Qodo fixes findings in a dedicated fix PR

More tips ↗ | Customize Qodo ↗ | Qodo docs ↗

Grey Divider

Qodo Logo

@widgetii
widgetii merged commit c6eb46f into master Nov 17, 2026
39 of 40 checks passed
@widgetii
widgetii deleted the majestic-af-bump-2431ae2 branch November 17, 2026 13:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant