Repository navigation
majestic-af: bump to 2431ae2 (no clicks, no stops, the right crest, a refocus after day/night) - #2883
Merged
Merged
Conversation
… refocus after day/night)
widgetii
requested review from
cronyx,
flyrouter and
viktorxda
as code owners
November 17, 2026 12:54
PR Summary by QodoBump majestic-af for safer lens motion and day/night refocus
AI Description
Diagram
High-Level Assessment
Files changed (1)
|
Code Review by Qodo🐞 Bugs (0) 📘 Rule violations (0) 📎 Requirement gaps (0)
Great, no issues found!Qodo reviewed your code and found no material issues that require reviewTip of the day💡 Did you know, you can enable the Remediation agent and Qodo fixes findings in a dedicated fix PR |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Bumps
majestic-afto OpenIPC/majestic-af#55 (2431ae2) for the HI3516D_N81820 speed dome of #2385.What changes on a camera (MS41908M lens backend and the af3 search):
ptz.lensHome, the lens's rest position is kept in/etc/majestic-af.lens. A start, or a WebUI save, no longer homes it into its stops. It homes only with no record, or after a move that was cut short.autofocus daynightby booking a pass once exposure has settled. It needs a majestic that sends it; an older majestic never does.Evidence. Run on the lab HI3516D_N81820 dome with that plugin binary, under
tools/clickguard, which listens through a second camera's microphone and stops the test on the first click. No click was heard in any of these:/night/onin the dark refocused a defocused lens to 380 by itself.The builder profile for that dome follows separately with the measured lens travel. The current 3000/3320 are longer than the lens.