Skip to content

hi3516dv100_lite_anxinshi-asrih698t: the lens travel measured end to end, and the old values corrected - #252

Merged
widgetii merged 1 commit into
masterfrom
asrih698t-measured-travel
Nov 17, 2026
Merged

widgetii merged 1 commit into
masterfrom
asrih698t-measured-travel

Conversation

@widgetii

Copy link
Copy Markdown
Member

The dome's lens travel, measured end to end on the lab HI3516D_N81820 dome (the OpenIPC/firmware#2385 model). Slow jogs ran into each stop under majestic-af's tools/clickguard, which listens through a second camera's microphone and stops the test on the first click:

  • Zoom: 2640 microsteps from the tele stop (configured: 3320).
  • Focus: 1300 microsteps from the near stop (configured: 3000).

The configured travel overshot both far stops, so a full move to either far end drove the motor into its stop.

This sets lensZoomSteps: 2580 and lensFocusSteps: 1240, 60 short of the far stops. With these limits, full-speed moves into all four limits were silent on the lab dome. majestic-af (OpenIPC/firmware#2883) keeps 100 microsteps clear of the home stops.

muxes.sh corrects the exact pair the earlier profile wrote (3320/3000) on the next boot and leaves any other value alone. The lower limits are safe with the current majestic-af too: they only keep the lens further from its stops.

…end, and the old values corrected

lensZoomSteps 3320 and lensFocusSteps 3000 were longer than the lens: every move to the far end of either drove its motor into the stop, and the clicking that went with it. Measured on a dome of this model with majestic-af's tools/clickguard listening for the stops: zoom 2640 microsteps from the tele stop, focus 1300 from the near stop. The limits are 2580 and 1240, 60 short of the far stops; majestic-af keeps 100 clear of the home ones.

muxes.sh corrects the exact pair the earlier profile wrote, on the next boot, and leaves any other value alone.
@qodo-free-for-open-source-projects

Copy link
Copy Markdown

PR Summary by Qodo

Correct ASRIH698T lens travel limits and migrate old settings

🐞 Bug fix 🕐 10-20 Minutes

Grey Divider

AI Description

• Set zoom and focus limits 60 microsteps short of measured far stops to prevent motor collisions.
• Correct the exact legacy settings pair on boot while preserving other configured values.
Diagram

graph TD
  C["Customizer defaults"] --> M["Boot muxes"] --> D{"Legacy pair?"} -->|Yes| R["Replace travel"] --> F["Fill missing settings"] --> J["Majestic AF"]
  D -->|No| F
Loading
High-Level Assessment

The exact-pair migration is appropriate: it repairs settings written by the earlier profile without replacing other values. Unconditional or per-key replacement would be simpler but could overwrite owner-configured travel limits.

Files changed (2) +20 / -7

Bug fix (2) +20 / -7
customizer.shUse measured lens limits during initial setup +2/-2

Use measured lens limits during initial setup

• Changes initial zoom and focus travel settings from 3320/3000 to 2580/1240 microsteps, keeping commanded travel short of the measured far stops.

devices/hi3516dv100_lite_anxinshi-asrih698t/general/overlay/usr/share/openipc/customizer.sh

muxes.shMigrate legacy travel values and correct boot defaults +18/-5

Migrate legacy travel values and correct boot defaults

• On boot, replaces travel limits only when both values match the earlier profile's 3320/3000 pair. Also uses 2580/1240 when either setting is absent and documents the measurements and stop clearance.

devices/hi3516dv100_lite_anxinshi-asrih698t/general/overlay/usr/share/openipc/muxes.sh

@qodo-free-for-open-source-projects

Copy link
Copy Markdown

Code Review by Qodo

🐞 Bugs (0) 📘 Rule violations (0) 📎 Requirement gaps (0)

Grey Divider

Great, no issues found!

Qodo reviewed your code and found no material issues that require review

Grey Divider

Tip of the day
💡 Did you know, you can enable the Remediation agent and Qodo fixes findings in a dedicated fix PR

More tips ↗ | Customize Qodo ↗ | Qodo docs ↗

Grey Divider

Qodo Logo

@widgetii
widgetii merged commit 9709185 into master Nov 17, 2026
7 checks passed
@widgetii
widgetii deleted the asrih698t-measured-travel branch November 17, 2026 13:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant