Repository navigation
Conversation
The frequency was already configured. This speeds up the unit test and causes no change to the test CSVs.
6 of 9 tasks
Global Size Summary (Total Flash delta in bytes)Built from bf99003 rebased onto f48fabc
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Skip reconfiguring the harmonic notch fundamental frequency on every sample.
Classification & Testing (check all that apply and add your own)
I diffed the test_notchfilter output before and after the patch - no difference.
Description
Since the filter frequency is already configured to
source_freq, and has not been changed since, we can skip reconfiguring it. This more closely matches how the filter is used, and causes no change to the generated test CSV files.Before: ~81 seconds
After: ~33 seconds