Repository navigation
buttonmaps: Use the DualShock 3 and 4 profiles for PlayStation controllers - #359
Conversation
…llers The button maps of PlayStation 3, 4 and 5 controllers were made when the PlayStation and PlayStation 2 profiles were the only ones, so Kodi shows them as a Dual Analog controller. controller-topology-project now has DualShock 3 and DualShock 4 profiles, so set their appearance to those. The controllers are told apart by USB id where the driver records one (054C:0268, 054C:09CC and 054C:0CE6) and by name otherwise. The DualSense is shown as a DualShock 4 until it has a profile of its own. Two DualShock 4 maps on the Linux driver had no appearance and get one. Maps for PSX-USB adaptors keep the Dual Analog appearance. Assisted-by: Claude
|
No actionable comments were generated in the recent review. Walkthrough
Merge Risk:
|
|
Merging now that xbmc/repo-resources#693 is in. |
@garbear asked for this in kodi-game/controller-topology-project#491 (comment). The button maps for PlayStation 3, 4 and 5 controllers set their appearance to
game.controller.ps.dualanalog(one togame.controller.ps.dualshock), as those were the only PlayStation profiles when they were made. This points them at the new DualShock 3 and DualShock 4 profiles instead.26 maps change: 10 DualShock 3, 11 DualShock 4 and 5 DualSense, which is shown as a DualShock 4 until it has a profile of its own. They're told apart by USB id where the driver records one (054C:0268, 054C:09CC and 054C:0CE6), and by name on the Linux driver, which doesn't. Two DualShock 4 maps on the Linux driver ("Wireless Controller") had no appearance and get one. The other five maps with the Dual Analog appearance (PSX-USB adaptors and one Android device) are left alone.
Only the appearance changes, no button mappings.
How has this been tested?
Not run in Kodi. The 26 files still parse, and only
<appearance>lines differ.Summary by CodeRabbit