Skip to content

buttonmaps: Use the DualShock 3 and 4 profiles for PlayStation controllers - #359

Merged
garbear merged 1 commit into
xbmc:Piersfrom
kel-mo:playstation-appearance
Nov 17, 2026
Merged

garbear merged 1 commit into
xbmc:Piersfrom
kel-mo:playstation-appearance

Conversation

@kel-mo

@kel-mo kel-mo commented Nov 17, 2026 •

Copy link
Copy Markdown

@garbear asked for this in kodi-game/controller-topology-project#491 (comment). The button maps for PlayStation 3, 4 and 5 controllers set their appearance to game.controller.ps.dualanalog (one to game.controller.ps.dualshock), as those were the only PlayStation profiles when they were made. This points them at the new DualShock 3 and DualShock 4 profiles instead.

26 maps change: 10 DualShock 3, 11 DualShock 4 and 5 DualSense, which is shown as a DualShock 4 until it has a profile of its own. They're told apart by USB id where the driver records one (054C:0268, 054C:09CC and 054C:0CE6), and by name on the Linux driver, which doesn't. Two DualShock 4 maps on the Linux driver ("Wireless Controller") had no appearance and get one. The other five maps with the Dual Analog appearance (PSX-USB adaptors and one Android device) are left alone.

Only the appearance changes, no button mappings.

How has this been tested?

Not run in Kodi. The 26 files still parse, and only <appearance> lines differ.

Summary by CodeRabbit

  • Bug Fixes
    • PlayStation 3 controller profiles now display the correct DualShock 3 appearance, and PlayStation 4 and DualSense profiles display the correct DualShock 4 appearance across supported platforms.
    • Controller button and axis mappings remain unchanged.

…llers

The button maps of PlayStation 3, 4 and 5 controllers were made when the
PlayStation and PlayStation 2 profiles were the only ones, so Kodi shows
them as a Dual Analog controller. controller-topology-project now has
DualShock 3 and DualShock 4 profiles, so set their appearance to those.

The controllers are told apart by USB id where the driver records one
(054C:0268, 054C:09CC and 054C:0CE6) and by name otherwise. The
DualSense is shown as a DualShock 4 until it has a profile of its own.
Two DualShock 4 maps on the Linux driver had no appearance and get one.
Maps for PSX-USB adaptors keep the Dual Analog appearance.

Assisted-by: Claude
@coderabbitai

coderabbitai Bot commented Nov 17, 2026 •

Copy link
Copy Markdown

Explain Change →

No actionable comments were generated in the recent review.

Walkthrough

Button-map XML configurations across Cocoa, DirectInput, Linux, and udev now assign PlayStation 3 and PlayStation 4 appearance IDs to matching controllers. Two Linux configurations add or populate the appearance setting.

Changes: PlayStation 3 appearance assignments

Layer / File(s) Summary
PlayStation 3 appearance assignments
peripheral.joystick/resources/buttonmaps/xml/cocoa/PLAYSTATION_R_3_Controller_v054C_p0268_19b_4a.xml, peripheral.joystick/resources/buttonmaps/xml/cocoa/PS_R__Ga_epad_v054C_p0268_19b_4a.xml, peripheral.joystick/resources/buttonmaps/xml/directinput/PS_R__Ga_epad_v054C_p0268_19b_5a.xml, peripheral.joystick/resources/buttonmaps/xml/linux/PLAYSTATION_R_3_Controller.xml, peripheral.joystick/resources/buttonmaps/xml/linux/PLAYSTATION_R_3_Controller_17b_29a.xml, peripheral.joystick/resources/buttonmaps/xml/linux/ShanWan_PS_R__Ga_epad_17b_6a.xml, peripheral.joystick/resources/buttonmaps/xml/linux/ShanWan_PS_R__Ga_epad_19b_27a.xml, peripheral.joystick/resources/buttonmaps/xml/linux/Sony_PLAYSTATION_R_3_Controller_17b_6a.xml, peripheral.joystick/resources/buttonmaps/xml/linux/Sony_PLAYSTATION_R_3_Controller_19b_27a.xml, peripheral.joystick/resources/buttonmaps/xml/udev/ShanWan_PS_R__Ga_epad_v054C_p0268_17b_6a.xml
These configurations now use the game.controller.ps3.dualshock3 appearance ID.
PlayStation 4 appearance assignments
peripheral.joystick/resources/buttonmaps/xml/cocoa/DUALSHOCK_4_Wireless_Controller_v054C_p09CC_14b_6a.xml, peripheral.joystick/resources/buttonmaps/xml/cocoa/Wireless_Controller_v054C_p09CC_14b_6a.xml, peripheral.joystick/resources/buttonmaps/xml/directinput/Wireless_Controller_v054C_p09CC_14b_1h_6a.xml, peripheral.joystick/resources/buttonmaps/xml/linux/DualSense_Wireless_Controller_13b_8a.xml, peripheral.joystick/resources/buttonmaps/xml/linux/DualSense_Wireless_Controller_Motion_Sensors_6a.xml, peripheral.joystick/resources/buttonmaps/xml/linux/Sony_Computer_Entertainment_Wireless_Controller_14b_18a.xml, peripheral.joystick/resources/buttonmaps/xml/linux/Sony_Interactive_Entertainment_DualSense_Wireless__13b_8a.xml, peripheral.joystick/resources/buttonmaps/xml/linux/Sony_Interactive_Entertainment_Wireless_Controller_13b_8a.xml, peripheral.joystick/resources/buttonmaps/xml/linux/Sony_Interactive_Entertainment_Wireless_Controller_14b_8a.xml, peripheral.joystick/resources/buttonmaps/xml/linux/Wireless_Controller_13b_8a.xml, peripheral.joystick/resources/buttonmaps/xml/linux/Wireless_Controller_14b_18a.xml, peripheral.joystick/resources/buttonmaps/xml/linux/Wireless_Controller_14b_8a.xml, peripheral.joystick/resources/buttonmaps/xml/udev/DualSense_Wireless_Controller_v054C_p0CE6_13b_8a.xml, peripheral.joystick/resources/buttonmaps/xml/udev/Sony_Interactive_Entertainment_DualSense_Wireless__v054C_p0CE6_13b_8a.xml, peripheral.joystick/resources/buttonmaps/xml/udev/Sony_Interactive_Entertainment_Wireless_Controller_v054C_p09CC_13b_8a.xml, peripheral.joystick/resources/buttonmaps/xml/udev/Sony_Interactive_Entertainment_Wireless_Controller_v054C_p09CC_14b_8a.xml
These configurations now use the game.controller.ps4.dualshock4 appearance ID. Two Linux configurations add or populate that setting; the described device and control mappings otherwise remain unchanged.

Estimated code review effort: 2 (Simple) | ~8 minutes

Change: Bug fix

Suggested reviewers: garbear, arucard21

Merge Risk: Minimal · up to bea89

This updates the controller artwork for PlayStation 3 and 4 controllers, and for DualSense controllers until they get a profile of their own. Button mappings are not touched. If a profile is not yet installed, Kodi falls back to its default appearance. The change is low-risk to merge.

Pre-merge checks: Passed 4

Check name Status Explanation
Description Check Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Title check Passed The title states the main change: the PlayStation controller button maps move from the Dual Analog appearance to the DualShock 3 and DualShock 4 appearances. The raw summary confirms that the 26 chang…
Linked Issues check Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check Passed Check skipped because no linked issues were found for this pull request.
Full details: Title check

Explanation

The title states the main change: the PlayStation controller button maps move from the Dual Analog appearance to the DualShock 3 and DualShock 4 appearances. The raw summary confirms that the 26 changed XML files set the appearance ID to game.controller.ps3.dualshock3 or game.controller.ps4.dualshock4, and the objectives say button mappings are unchanged. The title does not name the DualSense exception, which uses the DualShock 4 appearance, but it still covers the primary change.

  • Autofix · Keep fixing CodeRabbit findings and required CI, and resolving merge conflicts

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

Share

Recent review info

Run configuration

  • Source mode: Auto
  • Repository: Unavailable
  • Branch: Unavailable
  • File: No configuration file from this repository applied
  • Commit: Unavailable
  • Layers: Organization UI
  • Review profile: CHILL
  • Plan: Advanced
  • Run ID: 48833a69-ea2f-4ae0-9c5d-8450fe227d4a
Commits

Reviewing files that changed from the base of the PR and between 5bbcd95 and bea8982.

Files selected for processing: 26

  • peripheral.joystick/resources/buttonmaps/xml/cocoa/DUALSHOCK_4_Wireless_Controller_v054C_p09CC_14b_6a.xml
  • peripheral.joystick/resources/buttonmaps/xml/cocoa/PLAYSTATION_R_3_Controller_v054C_p0268_19b_4a.xml
  • peripheral.joystick/resources/buttonmaps/xml/cocoa/PS_R__Ga_epad_v054C_p0268_19b_4a.xml
  • peripheral.joystick/resources/buttonmaps/xml/cocoa/Wireless_Controller_v054C_p09CC_14b_6a.xml
  • peripheral.joystick/resources/buttonmaps/xml/directinput/PS_R__Ga_epad_v054C_p0268_19b_5a.xml
  • peripheral.joystick/resources/buttonmaps/xml/directinput/Wireless_Controller_v054C_p09CC_14b_1h_6a.xml
  • peripheral.joystick/resources/buttonmaps/xml/linux/DualSense_Wireless_Controller_13b_8a.xml
  • peripheral.joystick/resources/buttonmaps/xml/linux/DualSense_Wireless_Controller_Motion_Sensors_6a.xml
  • peripheral.joystick/resources/buttonmaps/xml/linux/PLAYSTATION_R_3_Controller.xml
  • peripheral.joystick/resources/buttonmaps/xml/linux/PLAYSTATION_R_3_Controller_17b_29a.xml
  • peripheral.joystick/resources/buttonmaps/xml/linux/ShanWan_PS_R__Ga_epad_17b_6a.xml
  • peripheral.joystick/resources/buttonmaps/xml/linux/ShanWan_PS_R__Ga_epad_19b_27a.xml
  • peripheral.joystick/resources/buttonmaps/xml/linux/Sony_Computer_Entertainment_Wireless_Controller_14b_18a.xml
  • peripheral.joystick/resources/buttonmaps/xml/linux/Sony_Interactive_Entertainment_DualSense_Wireless__13b_8a.xml
  • peripheral.joystick/resources/buttonmaps/xml/linux/Sony_Interactive_Entertainment_Wireless_Controller_13b_8a.xml
  • peripheral.joystick/resources/buttonmaps/xml/linux/Sony_Interactive_Entertainment_Wireless_Controller_14b_8a.xml
  • peripheral.joystick/resources/buttonmaps/xml/linux/Sony_PLAYSTATION_R_3_Controller_17b_6a.xml
  • peripheral.joystick/resources/buttonmaps/xml/linux/Sony_PLAYSTATION_R_3_Controller_19b_27a.xml
  • peripheral.joystick/resources/buttonmaps/xml/linux/Wireless_Controller_13b_8a.xml
  • peripheral.joystick/resources/buttonmaps/xml/linux/Wireless_Controller_14b_18a.xml
  • peripheral.joystick/resources/buttonmaps/xml/linux/Wireless_Controller_14b_8a.xml
  • peripheral.joystick/resources/buttonmaps/xml/udev/DualSense_Wireless_Controller_v054C_p0CE6_13b_8a.xml
  • peripheral.joystick/resources/buttonmaps/xml/udev/ShanWan_PS_R__Ga_epad_v054C_p0268_17b_6a.xml
  • peripheral.joystick/resources/buttonmaps/xml/udev/Sony_Interactive_Entertainment_DualSense_Wireless__v054C_p0CE6_13b_8a.xml
  • peripheral.joystick/resources/buttonmaps/xml/udev/Sony_Interactive_Entertainment_Wireless_Controller_v054C_p09CC_13b_8a.xml
  • peripheral.joystick/resources/buttonmaps/xml/udev/Sony_Interactive_Entertainment_Wireless_Controller_v054C_p09CC_14b_8a.xml

Included review availability: This review used your included allowance. Your plan provides up to 1 included review per hour; 0 remain after this review.

@garbear

garbear commented Nov 17, 2026

Copy link
Copy Markdown

Merging now that xbmc/repo-resources#693 is in.

@garbear
garbear merged commit 6ac841d into xbmc:Piers Nov 17, 2026
10 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants