Repository navigation
chore(deps): bump the npm-deps group across 1 directory with 7 updates - #115
dependabot[bot] wants to merge 1 commit into
Conversation
|
|
Review the following changes in direct dependencies. Learn more about Socket for GitHub.
|
71c1b52 to
396871d
Compare
29111e9 to
b2ba70d
Compare
| "typescript": "^5.3.3" | ||
| "@types/node": "^26.6.5", | ||
| "tsx": "^4.23.15", | ||
| "typescript": "^7.0.2" |
There was a problem hiding this comment.
🔴 After this bump, maintainers running pnpm check (tsc --noEmit) are likely to get config and type errors that TypeScript 5.9.3 does not raise. The unchanged tsconfig.json sets "moduleResolution": "node" (node10). TS 6.0 deprecated that and TS 7 removes it. It also omits types, which now defaults to [], so process in config.ts no longer resolves. Fix: migrate tsconfig.json in this PR. Use "moduleResolution": "bundler" (or "module"/"moduleResolution": "nodenext") and add "types": ["node"], then confirm pnpm check passes. Otherwise keep typescript on ^5.x.
Why this was flagged
The trigger is running the check script (tsc --noEmit, package.json:9) after a fresh install from the lockfile, which now pins typescript 7.0.2. examples/feepayer/client/tsconfig.json is not touched by this diff and still has "moduleResolution": "node", the node10 mode. TypeScript 6.0 deprecated it and 7.0 turns that into an error that the compiler option was removed. TS 6+ also defaults compilerOptions.types to [], so @ types/node no longer loads automatically. The process.env reads in config.ts (lines 14-27) would then fail with "Cannot find name 'process'". On the base branch, TS 5.9.3 accepts this tsconfig and loads @ types/node automatically, so check passes. skipLibCheck: true does not help because both errors come from the config and from the project's own sources, not from .d.ts files. I could not run tsc 7 in this environment, but the behavior follows TypeScript's published 6.0/7.0 deprecation schedule.
Verification: When anyone runs pnpm check (tsc --noEmit, package.json:9) after installing from the new lockfile, the type-check that passes on the base will fail. The lockfile pins typescript: specifier: ^7.0.2, version: 7.0.2 (pnpm-lock.yaml:30-32, 430). examples/feepayer/client/tsconfig.json is not touched by this diff and still has "moduleResolution": "node" (node10).
| "typescript": "^5.3.3" | ||
| "@types/node": "^26.6.5", | ||
| "tsx": "^4.23.15", | ||
| "typescript": "^7.0.2" |
There was a problem hiding this comment.
🔴 After the move to TypeScript 7, pnpm check probably reports "Cannot find name 'process'" and similar errors across both client files. TypeScript 6 and later default types to [], so @ types/node is no longer loaded automatically. The unchanged tsconfig.json sets lib: ["ES2022"] with no types entry, so process, console and btoa have no declarations. Fix: add "types": ["node"] to compilerOptions in tsconfig.json, or pin typescript to ^5. Fixing moduleResolution alone leaves these errors in place.
Why this was flagged
A maintainer runs the check script (tsc --noEmit, package.json:9) after installing from the new lockfile, which pins typescript 7.0.2. examples/feepayer/client/tsconfig.json sets "lib": ["ES2022"] and has no types field. Under TypeScript 5.9.3 every @ types/* package was included automatically, so @ types/node supplied globals like process. Starting with TypeScript 6.0, types defaults to [], so those globals are gone. The globals in question are used at config.ts:14-27 (process.env), config.ts:48 (btoa) and client.ts:8-72 (console). ES2022 lib does not declare any of them, because lib.dom is not included. The likely result is TS2580/TS2304 errors in both source files, where the base branch type-checks cleanly. This is separate from the filed moduleResolution: "node" findings and needs a different fix (types: ["node"]). Fixing only moduleResolution would still leave these errors. No CI job runs this client, so nothing catches the break before merge.
Verification: examples/feepayer/client/tsconfig.json is unchanged and sets "lib": ["ES2022"] with no types field. On TypeScript 5.9.3, @ types/node supplied process.env.* at config.ts:14-27, btoa(...) at config.ts:48 and console in client.ts:8-72. Starting with TypeScript 6.0, types defaults to [], and TypeScript 7 keeps that default, so @ types/node is no longer loaded.
b2ba70d to
3dd7ade
Compare
There was a problem hiding this comment.
Code review found no new issues
No new issues were found in this update; 2 findings from earlier reviews are still open above.
Still open from earlier reviews (2):
- 🔴
examples/feepayer/client/package.json:20—After this bump, maintainers running pnpm check (tsc --noEmit) are likely to get config and type errors that TypeScript… - 🔴
examples/feepayer/client/package.json:20—After the move to TypeScript 7, pnpm check probably reports "Cannot find name 'process'" and similar errors across both…
If you have decided not to act on one of these findings, resolve its thread (a reply alone leaves it open) and the next review stops counting it. To review this commit again now, use Re-run on its "Claude Code Review" check.
3dd7ade to
a80303a
Compare
There was a problem hiding this comment.
Code review found no new issues
No new issues were found in this update; 2 findings from earlier reviews are still open above.
Still open from earlier reviews (2):
- 🔴
examples/feepayer/client/package.json:20—After this bump, maintainers running pnpm check (tsc --noEmit) are likely to get config and type errors that TypeScript… - 🔴
examples/feepayer/client/package.json:20—After the move to TypeScript 7, pnpm check probably reports "Cannot find name 'process'" and similar errors across both…
If you have decided not to act on one of these findings, resolve its thread (a reply alone leaves it open) and the next review stops counting it. To review this commit again now, use Re-run on its "Claude Code Review" check.
a80303a to
bb44920
Compare
There was a problem hiding this comment.
Code review found no new issues
No new issues were found in this update; 2 findings from earlier reviews are still open above.
Still open from earlier reviews (2):
- 🔴
examples/feepayer/client/package.json:20—After this bump, maintainers running pnpm check (tsc --noEmit) are likely to get config and type errors that TypeScript… - 🔴
examples/feepayer/client/package.json:20—After the move to TypeScript 7, pnpm check probably reports "Cannot find name 'process'" and similar errors across both…
If you have decided not to act on one of these findings, resolve its thread (a reply alone leaves it open) and the next review stops counting it. To review this commit again now, use Re-run on its "Claude Code Review" check.
bb44920 to
78e99f3
Compare
Bumps the npm-deps group with 7 updates in the /examples/feepayer/client directory: | Package | From | To | | --- | --- | --- | | [@noble/curves](https://github.com/paulmillr/noble-curves) | `2.0.1` | `2.4.0` | | [dotenv](https://github.com/motdotla/dotenv) | `16.6.1` | `18.0.9` | | [tempo.ts](https://github.com/tempoxyz/tempo-ts) | `0.14.0` | `0.14.2` | | [viem](https://github.com/wevm/viem) | `2.57.4` | `2.57.16` | | [@types/node](https://github.com/DefinitelyTyped/DefinitelyTyped/tree/HEAD/types/node) | `25.2.0` | `26.6.6` | | [tsx](https://github.com/privatenumber/tsx) | `4.20.6` | `4.23.15` | | [typescript](https://github.com/microsoft/TypeScript) | `5.9.3` | `7.0.2` | Updates `@noble/curves` from 2.0.1 to 2.4.0 - [Release notes](https://github.com/paulmillr/noble-curves/releases) - [Changelog](https://github.com/paulmillr/noble-curves/blob/main/CHANGELOG.md) - [Commits](paulmillr/noble-curves@2.0.1...2.4.0) Updates `dotenv` from 16.6.1 to 18.0.9 - [Changelog](https://github.com/motdotla/dotenv/blob/master/CHANGELOG.md) - [Commits](motdotla/dotenv@v16.6.1...v18.0.9) Updates `tempo.ts` from 0.14.0 to 0.14.2 - [Release notes](https://github.com/tempoxyz/tempo-ts/releases) - [Changelog](https://github.com/tempoxyz/tempo-ts/blob/main/CHANGELOG.md) - [Commits](https://github.com/tempoxyz/tempo-ts/compare/tempo.ts@0.14.0...tempo.ts@0.14.2) Updates `viem` from 2.57.4 to 2.57.16 - [Release notes](https://github.com/wevm/viem/releases) - [Commits](https://github.com/wevm/viem/compare/viem@2.57.4...viem@2.57.16) Updates `@types/node` from 25.2.0 to 26.6.6 - [Release notes](https://github.com/DefinitelyTyped/DefinitelyTyped/releases) - [Commits](https://github.com/DefinitelyTyped/DefinitelyTyped/commits/HEAD/types/node) Updates `tsx` from 4.20.6 to 4.23.15 - [Release notes](https://github.com/privatenumber/tsx/releases) - [Changelog](https://github.com/privatenumber/tsx/blob/master/release.config.cjs) - [Commits](privatenumber/tsx@v4.20.6...v4.23.15) Updates `typescript` from 5.9.3 to 7.0.2 - [Release notes](https://github.com/microsoft/TypeScript/releases) - [Commits](microsoft/TypeScript@v5.9.3...v7.0.2) --- updated-dependencies: - dependency-name: "@noble/curves" dependency-version: 2.4.0 dependency-type: direct:production update-type: version-update:semver-minor dependency-group: npm-deps - dependency-name: "@types/node" dependency-version: 26.6.2 dependency-type: direct:development update-type: version-update:semver-major dependency-group: npm-deps - dependency-name: dotenv dependency-version: 18.0.2 dependency-type: direct:production update-type: version-update:semver-major dependency-group: npm-deps - dependency-name: tempo.ts dependency-version: 0.14.2 dependency-type: direct:production update-type: version-update:semver-patch dependency-group: npm-deps - dependency-name: tsx dependency-version: 4.23.15 dependency-type: direct:development update-type: version-update:semver-minor dependency-group: npm-deps - dependency-name: typescript dependency-version: 7.0.2 dependency-type: direct:development update-type: version-update:semver-major dependency-group: npm-deps - dependency-name: viem dependency-version: 2.56.8 dependency-type: direct:production update-type: version-update:semver-minor dependency-group: npm-deps ... Signed-off-by: dependabot[bot] <support@github.com>
78e99f3 to
a4d1d8f
Compare
There was a problem hiding this comment.
Code review found no new issues
No new issues were found in this update; 2 findings from earlier reviews are still open above.
Still open from earlier reviews (2):
- 🔴
examples/feepayer/client/package.json:20—After this bump, maintainers running pnpm check (tsc --noEmit) are likely to get config and type errors that TypeScript… - 🔴
examples/feepayer/client/package.json:20—After the move to TypeScript 7, pnpm check probably reports "Cannot find name 'process'" and similar errors across both…
If you have decided not to act on one of these findings, resolve its thread (a reply alone leaves it open) and the next review stops counting it. To review this commit again now, use Re-run on its "Claude Code Review" check.
Bumps the npm-deps group with 7 updates in the /examples/feepayer/client directory:
2.0.12.4.016.6.118.0.90.14.00.14.22.57.42.57.1625.2.026.6.64.20.64.23.155.9.37.0.2Updates
@noble/curvesfrom 2.0.1 to 2.4.0Release notes
Sourced from @noble/curves's releases.
... (truncated)
Changelog
Sourced from @noble/curves's changelog.
... (truncated)
Commits
656c436Release 2.4.0.ca081f6Add changelog783fa9bUpgrade noble-hashes to 2.4.03becb84readmebb52c57readme41f44d2Restructure benchmarks. Update README3587575Bump vectorsae43344Bump ci workflows5c1aa39Add fuzzingd5b95e4test: add more hardening-related testsMaintainer changes
This version was pushed to npm by GitHub Actions, a new releaser for
@noble/curvessince your current version.Updates
dotenvfrom 16.6.1 to 18.0.9Changelog
Sourced from dotenv's changelog.
... (truncated)
Commits
8d1ab8518.0.959a40cechangelog88228bdMerge pull request #1076 from Enesuygurs/fix/cli-empty-dotenv-pathbc6ef94fix(cli): load the default .env when DOTENV_PATH is empty6d6e6c5Merge pull request #1075 from kory-kaai/test/fast-parser-branch-coverage10218f1test(parse-fast): cover the size-dependent and export-prefix branchese2fe95e18.0.87aa712atype detail improvement53405b0Merge pull request #1074 from himanshu748/codex/fix-dotenv-populate-undefined...0b4843achangelogUpdates
tempo.tsfrom 0.14.0 to 0.14.2Release notes
Sourced from tempo.ts's releases.
Changelog
Sourced from tempo.ts's changelog.
Commits
8c41b50chore: version packages (#152)47ca27bfix: accept 0x78-prefixed transactions in Handler.feePayer (#151)2d3229cchore: version packages (#150)c2b57b9fix: bump viem, fix CI pipeline, migrate to tempoModerato (#149)7f5428ffix: remove eth_signTransaction from feePayer handler (#148)f898d00chore: repo cleanup (#147)b0527b2chore: remove playgroundd0c1ee6chore: remove examplesUpdates
viemfrom 2.57.4 to 2.57.16Release notes
Sourced from viem's releases.
... (truncated)
Commits
98aa491chore: raiseviem/enssize limit (#5398)71241b2chore: version package (#5393)e1329c9fix(tempo): check Gateway chain and refresh balances before payment errors (#...c60ca26feat(tempo): fund-aware Gateway payments and InsufficientFundsError (#5395)264ab41docs(tempo): use code groups with viem.config in Gateway guides (#5394)721d682feat(tempo): add experimental Gateway actions (#5391)9348d38perf: skip retries for method refusals and trim per-request overhead (#5392)5711b7echore: version package (#5363)dbf8ae6test: stabilizesendTransactionSynctimeout andwatchBlockscatch-up test...141f8c0feat(tempo): add Account.serialize, Account.deserialize and keyAuthorization ...Updates
@types/nodefrom 25.2.0 to 26.6.6Commits
Updates
tsxfrom 4.20.6 to 4.23.15Release notes
Sourced from tsx's releases.
... (truncated)
Commits
ca66105test: fix drive-less file URLs in ESM resolver fixtures2da3407fix: expose require.cache and require.extensions to tsImport CommonJS modules38e1588fix: exclude bare builtins from namespace inheritance562c434fix: make namespaced register() overloads portable for declaration emitedfb1f0build: upgrade pkgroll and externalize CJS loader reference70e7828test: upgrade tinyspy for disposable API9ed2022ci: avoid duplicate release notifications872e77frefactor: use disposables for cleanup6e5236bfix: restore the CJS bridge namespace for Node 24 require(esm) under tsImport...28e1f12fix(cache): bound shared transform cache memory (#835)Maintainer changes
This version was pushed to npm by GitHub Actions, a new releaser for tsx since your current version.
Updates
typescriptfrom 5.9.3 to 7.0.2Release notes
Sourced from typescript's releases.
Commits
1e4744dMerge branch 'main' into ts7-releasea5a219cmicrosoft/typescript-go#4558ecfe30dUpdate status localization5de25b5Hide executable name in TypeScript statusd7ce74aShow bundled TypeScript version for packaged servers29be66aCorrect TS 7 release version to 7.0.2ed2bd1bMerge branch 'main' into ts7-release8873075Bump the github-actions group across 1 directory with 3 updates (microsoft/ty...9427131Set up stable / nightly extension split, other prep (microsoft/typescript-go#...d4eaca5microsoft/typescript-go#4549Maintainer changes
This version was pushed to npm by microsoft1es, a new releaser for typescript since your current version.