Skip to content

Release partially acquired Machine leases when a deploy fails - #5529

Merged
tomr-fly merged 5 commits into
masterfrom
tomr/release-partial-deploy-leases
Nov 20, 2026
Merged

tomr-fly merged 5 commits into
masterfrom
tomr/release-partial-deploy-leases

Conversation

@tomr-fly

Copy link
Copy Markdown
Contributor

When a rolling deploy acquires a lease on one Machine but fails to acquire another, it can leave the first lease held until it expires. Release the leases acquired by that deploy before returning the error so other deploys can acquire them immediately.

@tomr-fly tomr-fly self-assigned this Nov 20, 2026
@tomr-fly tomr-fly added the bug Something isn't working label Nov 20, 2026

This comment was marked as resolved.

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🟢 Approval recommended

No active review issues remain, and the changes include regression coverage for releasing partial leases and recovering subsequent deployments.

No open issues 🎉

1 resolved since last review

Review effort: Lite

@tomr-fly
tomr-fly marked this pull request as ready for review November 20, 2026 22:40
@tomr-fly
tomr-fly requested a review from a team as a code owner November 20, 2026 22:40
@tomr-fly
tomr-fly merged commit a7faf13 into master Nov 20, 2026
27 of 28 checks passed
@tomr-fly
tomr-fly deleted the tomr/release-partial-deploy-leases branch November 20, 2026 22:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

bug Something isn't working

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants