Repository navigation
Conversation
Signed-off-by: Max Xu <xuhuan@live.cn>
Signed-off-by: Max Xu <xuhuan@live.cn>
Signed-off-by: Max Xu <xuhuan@live.cn>
Signed-off-by: Max Xu <xuhuan@live.cn>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Azure onboarding currently needs another customer apply when a new CloudEnvironment introduces resource groups. Add a separate onboarding module that creates the canonical identities, publishes nonsecret discovery hints and can install policy grants for future CE groups.
The explicit full-CE verification profile adds an RG-scoped custom assignment manager for automation. Its write/delete condition permits only Network Contributor, DNS Zone Contributor and Reader for service principals, excluding automation/support. Existing provisioning Terraform owns the resulting networking and DNS assignments. Automation receives no role-definition write permission, Owner or unconstrained IAM administrator role.
The profile requires an empty dedicated subscription, test/eastus, the RG deny guard, both node Reader policies and caller role-assignment metadata read. Narrow extra subscription metadata reads cover the provisioning providers. Default installation and fixed-target replay remain separate and unchanged.
Validation: Terraform format/validate, 17 mock plans, 9 Python tests and independent source review passed. Read-only Azure provider metadata confirmed the condition/version Policy aliases. No Azure resources were deployed for this change. The earlier fixed-target PoC had failed automatic node access; this full profile remains pending live manual verification.
Manual instructions:
modules/azure/vendor-access-onboarding/README.md. Do not install the full profile into shared SNCloud (Test). The guard affects all subscription callers. Its namespace rules do not establish ownership, and Azure conditions cannot constrain dynamic service-principal recipients to identities created in the same CE. The customer-controlled policy definitions and their managed identities are privileged trust boundaries; the workflow also verifies the exact delegation condition before proceeding.The supported full-flow preview uses new workload networking/DNS, a public AKS API endpoint and backups disabled. Velero requires a separate node-disk configuration and permission fix. Destroy owned workload resources before the installation; policy removal does not revoke previously deployed grants.
Design and original live evidence: https://github.com/streamnative/snip/pull/148
Coordinated drafts: terraform-managed-cloud #166 · cloud-api-server #5105 · apiserver-admin #162 · argo #1712 · cloud-controlplane-resources #2523 · cloud-api-client-typescript #129 · cloud-manager #5182 · sn-docs #1597