Repository navigation
bugfix: prevent select text descenders from being clipped - #4577
Open
anastasiia-baboshina wants to merge 4 commits into
Open
anastasiia-baboshina wants to merge 4 commits into
anastasiia-baboshina wants to merge 4 commits into
Conversation
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
|
@anastasiia-baboshina is attempting to deploy a commit to the Skeleton Labs Team on Vercel. A member of the Team first needs to authorize it. |
🦋 Changeset detectedLatest commit: 0825a87 The changes in this PR will be included in the next version bump. This PR includes changesets to release 6 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
anastasiia-baboshina
marked this pull request as ready for review
October 14, 2026 18:14
Contributor
|
I'm going to require input from @endigo9740 here, I'm not sure if we should hardcode a |
This branch was successfully deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Linked Issue(s)
Closes #4540
Description
The
selectutility setsline-height: var(--field-size)(1rem at the default size, so a line-height of exactly 1). On platforms where the browser appliesline-heightto a native<select>(the issue reports Windows 10 with Chrome/Edge, with Yu Gothic UI, Segoe UI and Montserrat), this clips the descenders of letters like g, y and p.This sets
line-height: normalonselect, as suggested in the issue.padding-blockis unchanged. Text inputs are already clamped to at leastnormalby the browser, so the select height now matches the input height.Testing on real Windows 11 (Chromium 152, device pixel ratio 1.25) with the skeleton.dev forms page: the native select honors
line-height(computed 16px), and the descender of "g" in "Los Angeles" is clipped with system-ui (Cerberus), Segoe UI, Yu Gothic UI and the font stack of the Crimson theme. Withline-height: normalit is no longer clipped in any of them, and the select height matches the input (about 35.3px vs 35.6px in Cerberus, 35.9px vs 35.85px in Crimson).line-height: 1.5also fixes the clipping, but makes the select 2-5px taller than the input. The select grows from about 30px to about 35px, which is the intended outcome since it now matches the input.On macOS and Linux (Chromium, Firefox, WebKit) the computed
line-heightof a native select is alreadynormal, so the bug does not reproduce there. I also compared before/after in headless Chromium on macOS with a static page built from the package CSS, emulating non-macOS rendering withappearance: none(select height 30px before, 31-35px after, matching the input).format:check,lint:checkandcheckpass.Not tested: Chrome and Edge themselves (I tested the Chromium engine they share), Firefox on Windows, Montserrat itself (not installed on the test machine, only the fallback stack of the Crimson theme), and the
field-xs/field-lg/field-3xlsizes.This PR was prepared with the help of Claude Code.
Checklist
Please read our contribution requirements and make sure you have:
docs/,feature/,task/,bugfix/mainbranch/packages)🤖 Generated with Claude Code