Repository navigation
reject whitespace inside An+B numbers in parse_series - #217
Merged
Merged
Conversation
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## master #217 +/- ##
=======================================
Coverage 99.80% 99.80%
=======================================
Files 3 3
Lines 1002 1014 +12
Branches 166 169 +3
=======================================
+ Hits 1000 1012 +12
Misses 1 1
Partials 1 1 ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
wRAR
approved these changes
Oct 25, 2026
AdrianAtZyte
approved these changes
Oct 26, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
parse_series() glues the :nth-*() argument tokens back together after parse_arguments() has dropped the whitespace between them, so
:nth-child(1 2)is translated as:nth-child(12),2n + 1 0as2n+10and2 nas2n(browsers reject all of these, An+B only allows whitespace around the sign of B), so this keeps a space wherever two tokens weren't adjacent in the source and only accepts it around that sign, leaving2n + 1,2n- 1and2n /* c */ + 1as they were.