Repository navigation
[save] safety_first translates only str values - #3256
Merged
Merged
Conversation
With safety_first on, iterdispvals added the newline/tab translate to every column, so typed savers (npy, arrow, parquet, xlsx, vds) saved ints, floats and dates as strings, and npy crashed calling isoformat() on a date that had become a str. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
With
safety_firston,iterdispvalsadded the newline/tab translate step to every column, including on theformat=Falsepath. Non-str values threw, and the except fell back tostr(value), so typed savers (npy, arrow, parquet, xlsx, vds) saved ints, floats and dates as strings. npy then crashed withAttributeError: 'str' object has no attribute 'isoformat'on date columns.Now the translate applies only to str values.
AI Level: 7 (Claude Opus 5.5 via Claude Code; requirements from @saulpw, not yet line-reviewed)
🤖 Generated with Claude Code