Repository navigation
Conversation
… and best-split optimization
sameerasw
added
enhancement
|
Thanks! This PR meets the contribution requirements and is queued for review. |
Owner
|
Hi @isaacsa51 can you address the conflcits? |
Owner
|
Oops... I hate this new PR layout |
sameerasw
marked this pull request as draft
November 8, 2026 14:58
…te_outline_from_expanded # Conflicts: # app/src/main/java/com/sameerasw/essentials/data/repository/SettingsRepository.kt # app/src/main/java/com/sameerasw/essentials/island/service/IslandCoordinator.kt # app/src/main/java/com/sameerasw/essentials/island/state/CompactCellWidths.kt # app/src/main/java/com/sameerasw/essentials/island/state/CompactLayoutEngine.kt # app/src/main/java/com/sameerasw/essentials/island/state/IslandController.kt # app/src/main/res/values-fr/strings.xml # app/src/main/res/values-ru/strings.xml # app/src/main/res/values-si/strings.xml # app/src/main/res/values-uk/strings.xml # app/src/main/res/values-vi/strings.xml
Contributor
Author
|
ready now @sameerasw |
isaacsa51
marked this pull request as ready for review
November 8, 2026 19:30
…te_outline_from_expanded # Conflicts: # app/src/main/java/com/sameerasw/essentials/island/ui/IslandRoot.kt
sameerasw
approved these changes
Nov 12, 2026
sameerasw
left a comment
sameerasw
left a comment
Owner
There was a problem hiding this comment.
Thanks for your contributions <3
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Small quick fix, current outline doesnt animate when the transition of expanded and outline off is enabled leaving to a pop of the outline render.
This PR just adds a quick animation/transition to it.
Type of change
UI changes
slow and manual expanded/collapsed transition leaving how the outline changes opacity given the transition between states.
Checklist
Before submitting, please make sure:
develop(notmain)../gradlew assembleDebug../gradlew testDebugUnitTest.SettingsRepositoryfor keys and getter/setter methods.FeatureRegistry.ktfor search indexing.ui/core/(RoundedCardContainer,IconToggleItem, etc.).res/values/strings.xmland drawables use rounded variants (R.drawable.rounded_*).