[ytmimi]

• I did not use an LLM to create a change in this PR.
• I used an LLM to create a change in this PR, and I have explained below how it was used.

Closes #7198
Also hides parse errors for tests added in #7171

[ytmimi]

Tests no longer output this parse error:

error: missing parameters for function definition
 --> tests/source/cfg-select-valid-then-invalid-item-error-count-leak.rs:6:31
  |
6 | cfg_select! { unix => { fn foo {} } }
  |                               ^
  |
help: add a parameter list
  |
6 | cfg_select! { unix => { fn foo() {} } }
  |                               ++

View changes since the review

[RalfJung]

Is it expected that rustfmt emits these errors, given that rustc might not emit an error (if the condition is false)?

[ytmimi]

rustfmt still needs to format all the cfg_select! arms even if they won't all be compiled so it seems reasonable to me that rustfmt would emit the parse error.

[ytmimi]

Without show_parse_errors: false the test output gets cluttered with this output:

error: expected identifier, found keyword `unsafe`
 --> tests/target/issue_7198.rs:8:17
  |
8 |                 unsafe extern "C" fn(*mut libc::c_void),
  |                 ^^^^^^ expected identifier, found keyword

error: expected one of `:` or `|`, found keyword `extern`
 --> tests/target/issue_7198.rs:8:24
  |
8 |                 unsafe extern "C" fn(*mut libc::c_void),
  |                        ^^^^^^ expected one of `:` or `|`

error: expected parameter name, found `*`
 --> tests/target/issue_7198.rs:9:17
  |
9 |                 *mut libc::c_void,
  |                 ^ expected parameter name

error: expected parameter name, found `*`
  --> tests/target/issue_7198.rs:10:17
   |
10 |                 *mut libc::c_void,
   |                 ^ expected parameter name

View changes since the review

[matthewhughes934]

thanks for this, I was about to get up a change for the same thing!

View changes since the review