Repository navigation
chore(gh): Overhaul PR template - #17612
Merged
Merged
Conversation
This is based on template experiments in my own repos
- Welcome message was removed in favor of triagebot
- Motivation description was shortened
- The second section was modified for how I use it in my own PRs
- "How to test" is not very specific and can lead people to saying
what CI will just do which is unintetesting
- Switched LLM "disclosure" to "involvement" which makes it more open
ended and less judgemental.
- I've seen people give very good but brief descriptions
- Removed the "remove this if no LLM" because that is ambiguous if its
missing and some LLM-looking PR descriptions have it missing
- Shortened the description, including removing the policy link since
triagebot will show it
rustbot
added
A-infrastructure
Collaborator
|
r? @weihanglo rustbot has assigned @weihanglo. Use Why was this reviewer chosen?The reviewer was selected based on:
|
weihanglo
reviewed
Oct 20, 2026
| --- | ||
|
|
||
| 🤖 LLM disclosure: _If an LLM was used in a way that requires disclosure under the [LLM usage policy](https://doc.crates.io/contrib/process/llm-usage.html), please describe it here. Remove this section if no disclosure is required._ | ||
| 🤖 LLM involvement: _How an LLM was used in preparing this change._ |
Member
There was a problem hiding this comment.
Shortened the description, including removing the policy link since triagebot will show it
One counterargument of removing links: In gh CLI or manual-opened PR, templates are visible before PR creation, while while triagebot is an aftermath comment.
Member
There was a problem hiding this comment.
Agreed; I think that having the link present may get people to read it before opening the PR.
weihanglo
approved these changes
Oct 20, 2026
Member
There was a problem hiding this comment.
Besides this #17612 (comment) I don't have other opinions. I guess we can merge and see how it goes.
weihanglo
enabled auto-merge
October 20, 2026 01:06
rustbot
removed
the
S-waiting-on-review
rust-bors Bot
pushed a commit
to rust-lang/rust
that referenced
this pull request
Oct 21, 2026
Update cargo submodule 12 commits in 3960fa69bb617e3d93c4ddc087c1b32bf12ad907..15be64aa0859b5c36f7a86d52f7aa0db44ba4d84 2026-10-12 19:29:05 +0000 to 2026-10-20 16:03:21 +0000 - feat(prerelease): support `[patch]` with `-Zprerelease` (rust-lang/cargo#17613) - chore(gh): Overhaul PR template (rust-lang/cargo#17612) - fix(util-schemas): compile out the file-path hint where url can't build it (rust-lang/cargo#17600) - feat(build-std): Add build.build-std.when and crates config keys (rust-lang/cargo#17602) - refactor(confg): Create a config abstraction (rust-lang/cargo#17606) - fix(config): Apply dotted tuple support for rustflags (rust-lang/cargo#17594) - Feat: Shell completion show all the packages having the feature (rust-lang/cargo#17574) - fix(config): Don't load registry config from credentials.toml (rust-lang/cargo#17599) - fix(fingerprint): choose a stable path when source mtimes tie (rust-lang/cargo#17521) - Update gix crates to address CVE-2026-82248, CVE-2026-82249, and CVE-2026-82250, and update git utils.rs to accommodate gix-url v0.38.0. (rust-lang/cargo#17484) - fix: check crate type when pruning `-L` paths (rust-lang/cargo#17589) - refactor(parser): Simplify dep source validation (rust-lang/cargo#17506) r? ghost
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What does this PR try to resolve?
This is based on template experiments in my own repos
Notes to reviewers
🤖 LLM disclosure: none