Repository navigation
Pass the search filter to grep as a pattern, not as options - #102
Open
bruno-costanzo wants to merge 1 commit into
Open
bruno-costanzo wants to merge 1 commit into
bruno-costanzo wants to merge 1 commit into
Conversation
Without ripgrep, a filter like -rvf reached grep as options and printed every file under Rails.root, master.key included.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Without ripgrep,
bin/super_greprangrep -E -h "$query_regex" "$file". The filter was grep's first argument, so a filter that starts with-became grep options.Filter
-rvfgivesgrep -E -h -rvf app.log:-f app.log: use the log lines as patterns-rwith no file left: search the working directory (Rails.root)-v: print the lines that do not matchSo the search returned every file under
Rails.root(config/master.key,.env) to anyone who can open the viewer.Fix:
-e "$query_regex"in both grep calls, and--before the file.super_ripgrepalready used-e, so apps with ripgrep were not affected.The test searches
-rvfwith both engines, for the whole file and for a byte range. Before the fix it returned the content ofsecret.txt.