Repository navigation
Conversation
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary:
KeyboardAvoidingViewfollows the keyboard from JavaScript: it waits for a keyboard event, then animates its layout once withLayoutAnimation. The content does not move in sync with the keyboard, and interactive dismissal is not followed at all.This PR adds an
experimental_nativeprop, inspired byreact-native-keyboard-controller. When it is set, a native view follows the keyboard frame by frame (UIKeyboardLayoutGuideon iOS,WindowInsetsAnimationCompaton Android) and sends the inset to the shared animation backend, which applies it to the layout.Note that it requires the
useSharedAnimatedBackendfeature flag and an edge-to-edge app; otherwise, the JavaScript implementation (current) is used.In following PRs, I plan to add
keyboardWillShowandkeyboardWillHideevents, and possibly atranslate-with-paddingbehavior and aKeyboardAwareScrollViewcomponent.Changelog:
[GENERAL] [ADDED] - Add
experimental_nativeprop toKeyboardAvoidingViewto follow the keyboard animation nativelyTest Plan:
Commands I ran, and their results:
yarn flow-check: no erroryarn build-types && yarn test-generated-typescript: passedyarn eslint --max-warnings 0on changed JS files: cleanyarn test packages/react-native/Libraries/Components/Keyboard: passedyarn format-check-kotlinandyarn format-check-javascript: passedyarn cxx-api-build: snapshots updatedVideos
Android
Android.mp4
iOS
iOS.mp4