Repository navigation
Delete skipped legacy-bridge unit tests (#59321) - #59321
Closed
christophpurrer wants to merge 1 commit into
Closed
christophpurrer wants to merge 1 commit into
christophpurrer wants to merge 1 commit into
Conversation
meta-cla
Bot
added
the
CLA Signed
|
@christophpurrer has exported this pull request. If you are a Meta employee, you can view the originating Diff in D126581181. |
christophpurrer
added a commit
to christophpurrer/react-native-macos
that referenced
this pull request
Oct 21, 2026
Summary: Pull Request resolved: react#59321 RCTModuleInitTests and RCTModuleInitNotificationRaceTests skip every test since they rely on the removed bridge. RCTAllocationTests keeps only its live module-method deallocation test. Remove the dead files from the Xcode project. Changelog: [Internal] Differential Revision: D126581181
christophpurrer
force-pushed
the
export-D126581181
branch
from
October 21, 2026 21:03
26f02a4 to
c1466ed
Compare
meta-codesync
Bot
changed the title
christophpurrer
added a commit
to christophpurrer/react-native-macos
that referenced
this pull request
Oct 22, 2026
Summary: Pull Request resolved: react#59321 RCTModuleInitTests and RCTModuleInitNotificationRaceTests skip every test since they rely on the removed bridge. RCTAllocationTests keeps only its live module-method deallocation test. Remove the dead files from the Xcode project. Changelog: [Internal] Reviewed By: shwanton Differential Revision: D126581181
christophpurrer
force-pushed
the
export-D126581181
branch
from
October 22, 2026 19:38
c1466ed to
b08c60d
Compare
Summary: RCTModuleInitTests and RCTModuleInitNotificationRaceTests skip every test since they rely on the removed bridge. RCTAllocationTests keeps only its live module-method deallocation test. Remove the dead files from the Xcode project. Changelog: [Internal] Reviewed By: shwanton Differential Revision: D126581181
christophpurrer
force-pushed
the
export-D126581181
branch
from
October 23, 2026 04:03
b08c60d to
bfa19b8
Compare
Collaborator
|
This pull request was successfully merged by @christophpurrer in 2b71bb2 When will my fix make it into a release? | How to file a pick request? |
|
This pull request has been merged in 2b71bb2. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary:
RCTModuleInitTests and RCTModuleInitNotificationRaceTests skip every
test since they rely on the removed bridge. RCTAllocationTests keeps
only its live module-method deallocation test. Remove the dead files
from the Xcode project.
Changelog:
[Internal]
Reviewed By: shwanton
Differential Revision: D126581181