Repository navigation
fix(builder): escape slashes in credentials - #167
Open
awais-ur-rehman wants to merge 1 commit into
Open
awais-ur-rehman wants to merge 1 commit into
awais-ur-rehman wants to merge 1 commit into
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
URIBuilder.add_credentials('user', 'pass/word')currently emits an unescaped slash, so parsing the resulting URL moves part of the credentials and the intended hostname into the path. Escape slashes in both credential fields so they stay inside the authority, as required by RFC 3986 section 3.2.1, and test that serializing and parsing preserves the host, userinfo, and path.Breaking changes
None.
Testing
python -m pytest --cov rfc3986 --cov-fail-under 100 tests/: 2917 passed, 100% coverage on Python 3.12.13 (1517 existing deprecation warnings).black --check src/rfc3986 tests/,isort --check-only src/rfc3986 tests/,flake8 src/rfc3986, andgit diff --checkpass.python tests/verify_types.py: 76.87% type completeness, above the required 75%.python -m build --no-isolation: sdist and wheel built successfully (setuptools deprecation notices).