Repository navigation
fix: resync range slider handle label when handle can't reach edited value - #358
Merged
Merged
Conversation
…value Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #358 +/- ##
==========================================
+ Coverage 84.81% 84.84% +0.02%
==========================================
Files 49 49
Lines 3924 3925 +1
==========================================
+ Hits 3328 3330 +2
+ Misses 596 595 -1 ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
small fix I noticed while reviewing #353. if you type a value into a
QLabeledRangeSliderhandle label that the handle can't actually move to (e.g. it's blocked by a neighboring handle) and the slider value doesn't change as a result, the label is never resynced... so it keeps showing whatever it clamped to rather than the real handle position.for example, with range
(0, 100)and value(20, 50, 80), typing 500 into the middle label twice: the first edit moves the handle to 79, but the second leaves the label showing100while the handle is still at 79.this just sets the label back to the actual handle value after
setSliderPosition. It doesn't conflict with #353 (which makes this more visible, since withsetExpandRangeOnHandleEdit(True)the label isn't clamped at all and would show500).🤖 Generated with Claude Code