Repository navigation
Conversation
Codex Review SummaryThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
For
SlidingWindow(duration=0.025, step=0.01),samples(0.01, mode="strict")returns-1, although no frame fits. That negative count also reaches fixed-duration feature cropping: an interval at the start or beyond the end of the features raisesValueError: negative dimensions are not allowed.Clamp the strict frame count to zero when the requested duration cannot contain a complete frame. Loose/center counts and ordinary strict counts are unchanged. Tests cover zero and short durations plus fixed crops before, within and after the available features.
Full suite: 71 pass on Python 3.12/NumPy 2.5.4; 69 pass with two optional IPython visualization skips on Python 3.11/NumPy 2.0.2. Ruff checks and formatting pass.
A separate workflow uses frame features from six recorded CMU Arctic utterances and independently enumerates fully contained windows. All 54 negative counts become zero, all 36 formerly failing boundary crops return the expected empty array, and 24 ordinary crops retain exactly the same selected frame values. No padding or alignment rule is changed for spans that contain frames.