Skip to content

ComputePacboyPackages: pyTooling's extra 'dependencies' needs the ruamel.yaml packages - #336

Merged
Paebbels merged 1 commit into
devfrom
claude/pacboy-dependencies-yaml
Oct 29, 2026
Merged

Paebbels merged 1 commit into
devfrom
claude/pacboy-dependencies-yaml

Conversation

@pytooling-claude

Copy link
Copy Markdown

GitHub Pipeline

  • ComputePacboyPackages: pyTooling's extra dependencies maps to python-aiohttp:p python-ruamel-yaml:p python-ruamel.yaml.clib:p (was python-aiohttp:p only), as pyTooling v10.1.1's extra requires ruamel.yaml (Extra 'dependencies' includes ruamel.yaml (license overrides file) pyTooling#684). Without it, an MSYS2 job installing pyTooling[dependencies] would build ruamel.yaml's C extension from source instead of taking MSYS2's package.
  • tests/pacman_packages.py, the standalone copy of the inline script: the same mapping.
  • _Checking_Parameters.yml: the expected package set is unchanged - pyTooling[yaml] in the same requirement already contributes both packages; the comments name pyTooling[dependencies] too.

Related Issues and Pull-Requests

…mel.yaml packages.

pyTooling v10.1.1's extra 'dependencies' requires ruamel.yaml (pyTooling/pyTooling#684): its MSYS2 mapping adds
python-ruamel-yaml and python-ruamel.yaml.clib beside python-aiohttp, in the action and in its standalone copy
tests/pacman_packages.py. The expected set of _Checking_Parameters.yml is unchanged (pyTooling[yaml] already
contributes both packages); its comments name the extra too.

Co-Authored-By: Patrick Lehmann <Paebbels@gmail.com>
@pytooling-claude
pytooling-claude Bot requested a review from Paebbels as a code owner October 29, 2026 06:59
@pytooling-claude pytooling-claude Bot added CI: GitHub Actions Continuous Integration issues related to GitHub Actions (Windows, Linux and MacOS) Dependencies Used by Dependabot. labels Oct 29, 2026
@codacy-production

codacy-production Bot commented Oct 29, 2026 •

Copy link
Copy Markdown

Up to standards ✅

🟢 Issues 0 issues

Results:
0 new issues

View in Codacy

🟢 Metrics 6 complexity · 0 duplication

Metric Results
Complexity 6
Duplication 0

View in Codacy

🟢 Coverage ∅ diff coverage

Metric Results
Coverage variation Report missing for 03263c81
Diff coverage ✅ ∅ diff coverage

View coverage diff in Codacy

Coverage variation details
Coverable lines Covered lines Coverage
Common ancestor commit (03263c8) Report Missing Report Missing Report Missing
Head commit (a8c4f7b) 41 38 92.68%

Coverage variation is the difference between the coverage for the head and common ancestor commits of the pull request branch: <coverage of head commit> - <coverage of common ancestor commit>

Diff coverage details
Coverable lines Covered lines Diff coverage
Pull request (#336) 0 0 ∅ (not applicable)

Diff coverage is the percentage of lines that are covered by tests out of the coverable lines that the pull request added or modified: <covered lines added or modified>/<coverable lines added or modified> * 100%

1 Codacy didn't receive coverage data for the commit, or there was an error processing the received data. Check your integration for errors and validate that your coverage setup is correct.

NEW Get contextual insights on your PRs based on Codacy's metrics, along with PR and Jira context, without leaving GitHub. Enable AI reviewer
TIP This summary will be updated as you push new changes.

@codecov

codecov Bot commented Oct 29, 2026 •

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 85.36%. Comparing base (ec01b91) to head (a8c4f7b).
⚠️ Report is 3 commits behind head on dev.
✅ All tests successful. No failed tests found.

Additional details and impacted files
@@             Coverage Diff             @@
##              dev     #336       +/-   ##
===========================================
+ Coverage   65.85%   85.36%   +19.51%     
===========================================
  Files           1        1               
  Lines          41       41               
  Branches        7        7               
===========================================
+ Hits           27       35        +8     
+ Misses         13        3       -10     
- Partials        1        3        +2     
Flag Coverage Δ
unittests 85.36% <ø> (+19.51%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Harness.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@Paebbels
Paebbels merged commit 7c5d462 into dev Oct 29, 2026
181 of 184 checks passed
@Paebbels
Paebbels deleted the claude/pacboy-dependencies-yaml branch October 29, 2026 14:29
This was referenced Oct 29, 2026

This branch had an error being deployed

1 failed deployment
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

CI: GitHub Actions Continuous Integration issues related to GitHub Actions (Windows, Linux and MacOS) Dependencies Used by Dependabot.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants