Repository navigation
fix: createRadio().disable(false) does not re-enable radio inputs - #9338
Open
aryanb1906 wants to merge 1 commit into
Open
aryanb1906 wants to merge 1 commit into
aryanb1906 wants to merge 1 commit into
Conversation
setAttribute('disabled', false) sets the attribute to the string "false",
which still counts as present and keeps the input disabled. Using the DOM
property (radioInput.disabled = shouldDisable) correctly enables/disables.
Closes processing#9316
|
🎉 Thanks for opening this pull request! For guidance on contributing, check out our contributor guidelines and other resources for contributors! Thank You! |
1 of 19 tasks
Author
|
Resolves #9316 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
createRadio().disable(false)not re-enabling radio inputssetAttribute('disabled', false)sets the attribute to the string "false", which HTML still treats as "present" so the input stays disabledradioInput.disabled = shouldDisable) instead ofsetAttribute, which correctly toggles enable/disableTest plan
Closes #9316