Repository navigation
Conversation
Signed-off-by: lhy1024 <19542290+lhy1024@users.noreply.github.com>
|
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: The full list of commands accepted by this bot can be found here. DetailsNeeds approval from an approver in each of these files:Approvers can indicate their approval by writing |
ti-chi-bot
Bot
added
the
missing-translation-status
ti-chi-bot
Bot
added
the
size/XS
|
Note Reviews pausedIt looks like this branch is under active development. To avoid overwhelming you with review comments due to an influx of new commits, CodeRabbit has automatically paused this review. You can configure this behavior by changing the
Use the following commands to manage reviews:
Use the checkboxes below for quick actions:
No actionable comments were generated in the recent review.
 |
| Layer / File(s) | Summary |
|---|---|
Document label-property support and alternatives pd-configuration-file.md, pd-microservices.md |
The pages state that scheduling does not support label-property and identify Placement Rules or evict-leader-scheduler as alternatives. The microservices page also describes the effect of reject-leader label properties and when label-property takes effect through enable-scheduling-fallback. |
Priority:
Estimated code review effort: 1 (Trivial) | ~4 minutes
Change: Other
Suggested reviewers: qiancai
Merge Risk: 
cf4d1
-
The documentation accurately describes the currently evidenced scheduling behavior and available alternatives; no merge-blocking risk remains.
Pre-merge checks: 
-
Check name Status Explanation Title check The title names the main change: the scheduling microservice does not support label-property. It is specific, concise, and matches the raw summary and PR objectives. Description check The description states what changed, which versions are affected, and links related PRs and issues. It also fills the AI agent involvement section. The 'What is changed' section is complete. The templ… Docstring Coverage No eligible functions found in the changed files. Skipping docstring coverage check. Docstring coverage is scoped to functions touched by this diff with cyclomatic complexity of at least 2. Documentat… Linked Issues check Check skipped because no linked issues were found for this pull request. Out of Scope Changes check Check skipped because no linked issues were found for this pull request. Full details: Description check
-
Explanation
The description states what changed, which versions are affected, and links related PRs and issues. It also fills the AI agent involvement section. The 'What is changed' section is complete. The template's 'Required' sections are filled. The first-time contributor checklist is omitted, which is acceptable because it applies only to first-time contributors.
Full details: Docstring Coverage
-
Explanation
No eligible functions found in the changed files. Skipping docstring coverage check. Docstring coverage is scoped to functions touched by this diff with cyclomatic complexity of at least 2. Documentation-only edits and deletions within surviving functions are included; unchanged diff context and fully deleted functions are excluded. Analyzed 0 functions across 0 files. (1 skipped: 1 unsupported.)
-
Finishing Touches
-
🧪 Generate unit tests (beta)
-
- Create a new PR
-
- Autofix · Keep fixing CodeRabbit findings and required CI, and resolving merge conflicts
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.
Comment @coderabbitai help to get the list of available commands.
lhy1024
added
needs-cherry-pick-release-8.1
![coderabbitai[bot]](https://avatars.githubusercontent.com/in/347564?s=60&v=4){kind=small}
There was a problem hiding this comment.
Actionable comments posted: 1
-
-
- Source mode: Auto
- Repository: pingcap/docs
- Branch: master
- File: .coderabbit.yaml
- Commit: e5e80ae
- Layers: Repository YAML
- Review profile: ASSERTIVE
- Plan: Advanced
- Run ID:
95f456ba-cfc9-436f-be51-0f85f43d7270
-
pd-configuration-file.mdpd-microservices.md
Included review availability: This review used your included allowance. Your plan provides up to 4 included reviews per hour; 3 remain after this review.
-
Signed-off-by: lhy1024 <19542290+lhy1024@users.noreply.github.com>
Signed-off-by: lhy1024 <19542290+lhy1024@users.noreply.github.com>
What is changed, added, or deleted? (Required)
Clarify that the
schedulingmicroservice does not support the deprecatedlabel-propertyconfiguration. Add this restriction to the PD microservices page and add a note to thelabel-propertysection recommending Placement Rules orevict-leader-schedulerto keep leaders off specific stores.Which TiDB version(s) do your changes apply to? (Required)
What is the related PR or file link(s)?
AI agent involvement
Do your changes match any of the following descriptions?
Summary by CodeRabbit
schedulingmicroservice does not support the deprecatedlabel-propertyconfiguration in PD microservice mode, soreject-leaderlabel properties have no effect while it is enabled.evict-leader-schedulerto keep leaders off specific stores.label-propertytakes effect again when PD schedules throughenable-scheduling-fallbackbecause noschedulingmicroservice is available.