Repository navigation
table-affinity: clarify scheduling microservice version support #24206
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
lhy1024
wants to merge
5
commits into
pingcap:master
Choose a base branch
from
lhy1024:fix/affinity-microservices-version
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Changes from all commits
Commits
Show all changes
5 commits
Select commit
Hold shift + click to select a range
ef5d754
table-affinity: clarify scheduling microservice version support
lhy1024 40344f0
table-affinity: describe microservice support positively
lhy1024 43e2afa
table-affinity: use verified microservice support version
lhy1024 1d64d5f
table-affinity: distinguish deployment mode support versions
lhy1024 e70d552
table-affinity: correct microservice support version
lhy1024 File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
🎯 Functional Correctness | 🟡 Minor | ⚡ Quick win
🔎 Supported by static analysis
🏁 Script executed:
Repository: pingcap/docs
Length of output: 7915
🌐 Web query:
site:github.com/tikv/pd v8.5.7 pkg/schedule/affinity/split.go grpc_service.go MCS scheduling affinity split💡 Result:
Document both automatic-splitting triggers for MCS.
The new availability statement makes the automatic-splitting note apply to MCS. In v8.5.7,
AskBatchSplitcallsAllowSplit, which permits splitting when approximate size reaches(configured merge size + 10 MiB) × 4or approximate key count reaches its threshold. The current “only when ... exceeds four times” wording can cause operators to miss key-count-triggered splits and use an incorrect size threshold.Suggested fix