Repository navigation
Download the PHPStan Pro PHAR of the current platform - #7017
Merged
Merged
Conversation
PHPStan Pro PHARs bundle a native binary now, so /latest gets the os
(PHP_OS_FAMILY) and arch (php_uname('m')) of the system and answers the
PHAR of its platform.
phar-info.json remembers the URL, os and arch of the downloaded PHAR.
A PHAR downloaded on another system (the directory was carried over, or
is shared with a Docker container) or by an older PHPStan is deleted and
downloaded again, and so is one whose URL /latest no longer answers.
Amp-Thread-ID: https://ampcode.com/threads/T-01a1c135-4a5f-71d6-8fd1-dd47a96f2e3a
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
PHPStan Pro PHARs will bundle a native binary, one PHAR per platform.
/latestgetsos(PHP_OS_FAMILY) andarch(php_uname('m')), and the download API answers the PHAR of that platform. Until PHPStan Pro publishes per-platform PHARs, the API ignores them, so this can be released first.phar-info.jsonremembers theurl,osandarchof the downloaded PHAR. A PHAR downloaded on another system (the temp directory carried over, or shared with a Docker container) or by an older PHPStan is deleted and downloaded again, so that a failed download doesn't fall back to a PHAR whose binary can't run here. A PHAR whose URL/latestno longer answers is downloaded again too.