Skip to content
Merged
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
22 changes: 0 additions & 22 deletions crates/stateless/src/zkvm_interface.rs
Original file line number Diff line number Diff line change
Expand Up @@ -170,13 +170,6 @@ impl Crypto for ZkVMInterfaceCrypto {
&self,
pairs: &mut dyn Iterator<Item = Result<G1PointScalar, PrecompileHalt>>,
) -> Result<[u8; 96], PrecompileHalt> {
#[cfg(target_vendor = "zisk")]
let pairs = {
let pairs = pairs.collect::<Result<Vec<_>, _>>()?;
validate_zisk_bls12_g1_subgroups(pairs.iter().map(|(point, _)| *point))?;
pairs.into_iter().map(Ok)
};

let pairs: Vec<zkvm_bls12_381_g1_msm_pair> = pairs
.map(|pair| {
let (point, scalar) = pair?;
Expand Down Expand Up @@ -226,9 +219,6 @@ impl Crypto for ZkVMInterfaceCrypto {
&self,
pairs: &[(G1Point, G2Point)],
) -> Result<bool, PrecompileHalt> {
#[cfg(target_vendor = "zisk")]
validate_zisk_bls12_g1_subgroups(pairs.iter().map(|(point, _)| *point))?;

let pairs: Vec<zkvm_bls12_381_pairing_pair> = pairs
.iter()
.map(|(g1, g2)| zkvm_bls12_381_pairing_pair {
Expand Down Expand Up @@ -364,18 +354,6 @@ fn keccak256(data: &[u8]) -> [u8; 32] {
output.data
}

#[cfg(target_vendor = "zisk")]
fn validate_zisk_bls12_g1_subgroups(
points: impl Iterator<Item = G1Point>,
) -> Result<(), PrecompileHalt> {
// ZisK's G1 MSM and pairing hints panic instead of rejecting non-subgroup points.
let mut points = points.collect::<Vec<_>>();
points.sort_unstable();
points.dedup();
let mut pairs = points.into_iter().map(|point| Ok((point, [0; 32])));
DefaultCrypto.bls12_381_g1_msm(&mut pairs).map(|_| ())
}

#[inline]
fn pack_bls12_381_g1(p: &G1Point) -> zkvm_bls12_381_g1_point {
let mut data = [0u8; 96];
Expand Down
Loading