Skip to content

chore: update to tests-zkevm@v21.0.7 and reject malformed witness trie nodes - #61

Merged
figtracer merged 1 commit into
paradigmxyz:mainfrom
jsign:jsign/update-tests-zkevm-v21
Nov 11, 2026
Merged

figtracer merged 1 commit into
paradigmxyz:mainfrom
jsign:jsign/update-tests-zkevm-v21

Conversation

@jsign

@jsign jsign commented Nov 11, 2026

Copy link
Copy Markdown
Contributor

This PR updates the execution-spec fixtures from tests-zkevm@v21.0.6 to tests-zkevm@v21.0.7. The release changes the new_payload_request_root the guest outputs, and adds tests with malformed witness trie nodes that a guest must reject.

Besides the new roots, the fixtures found two problems. The guest accepted a witness with an oversized embedded leaf, and a new EIP-7685 test hits an alloy-evm bug we already track.

This PR:

  • Makes every NewPayloadRequest variant a progressive container and caps versioned_hashes at 4096 entries, to match the Gloas consensus spec (fix(zkevm): align NewPayloadRequest and StatelessValidationResult SSZ types with Gloas ethereum/execution-specs#3913). The encoding stays the same, so only the root changes. The spec only defines the Amsterdam type, but I applied it to the older forks too, as we already do for the payload types. I computed the new reference roots with remerkleable, after checking that it reproduces the existing ones.
  • Makes zeth-mpt reject an embedded child of 32 bytes or more, and a hash reference to a non-root node shorter than 32 bytes (feat(zkevm): check witness trie nodes only when the block reaches them ethereum/execution-specs#3934). It already rejected branches holding a value.
  • Adds test_withdrawals_credited_before_request_system_call to KNOWN_FAILURES. The test checks that withdrawals are credited before the request system calls, but alloy-evm runs them in the reverse order. It's the same bug behind the EIP-7928 entries.
  • Updates the expected output in guest-smoke.json, which carries the new root.

The spec now checks a witness node only when the block reaches it, but it still allows a guest to check every node up front, so zeth keeps checking them all when it builds the trie.

…e nodes

The release makes NewPayloadRequest a progressive container with versioned_hashes capped at 4096, which changes its root. It also adds witness tests that the zeth trie decoder failed, since it accepted oversized embedded children and short nodes referenced by hash.
@jsign
jsign marked this pull request as ready for review November 11, 2026 17:35
@figtracer
figtracer merged commit e5837d7 into paradigmxyz:main Nov 11, 2026
13 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants