Repository navigation
chore: update to tests-zkevm@v21.0.7 and reject malformed witness trie nodes - #61
Merged
Merged
Conversation
…e nodes The release makes NewPayloadRequest a progressive container with versioned_hashes capped at 4096, which changes its root. It also adds witness tests that the zeth trie decoder failed, since it accepted oversized embedded children and short nodes referenced by hash.
jsign
marked this pull request as ready for review
November 11, 2026 17:35
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR updates the execution-spec fixtures from
tests-zkevm@v21.0.6totests-zkevm@v21.0.7. The release changes thenew_payload_request_rootthe guest outputs, and adds tests with malformed witness trie nodes that a guest must reject.Besides the new roots, the fixtures found two problems. The guest accepted a witness with an oversized embedded leaf, and a new EIP-7685 test hits an alloy-evm bug we already track.
This PR:
NewPayloadRequestvariant a progressive container and capsversioned_hashesat 4096 entries, to match the Gloas consensus spec (fix(zkevm): align NewPayloadRequest and StatelessValidationResult SSZ types with Gloas ethereum/execution-specs#3913). The encoding stays the same, so only the root changes. The spec only defines the Amsterdam type, but I applied it to the older forks too, as we already do for the payload types. I computed the new reference roots with remerkleable, after checking that it reproduces the existing ones.zeth-mptreject an embedded child of 32 bytes or more, and a hash reference to a non-root node shorter than 32 bytes (feat(zkevm): check witness trie nodes only when the block reaches them ethereum/execution-specs#3934). It already rejected branches holding a value.test_withdrawals_credited_before_request_system_calltoKNOWN_FAILURES. The test checks that withdrawals are credited before the request system calls, but alloy-evm runs them in the reverse order. It's the same bug behind the EIP-7928 entries.guest-smoke.json, which carries the new root.The spec now checks a witness node only when the block reaches it, but it still allows a guest to check every node up front, so zeth keeps checking them all when it builds the trie.