Repository navigation
Avoid main-thread hangs by size-capping and lazily indexing known files for edit path inference - #3430
Open
sentry[bot] wants to merge 2 commits into
Open
Avoid main-thread hangs by size-capping and lazily indexing known files for edit path inference#3430sentry[bot] wants to merge 2 commits into
sentry[bot] wants to merge 2 commits into
Conversation
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Fixes an issue where
ChatSession.rebuildVisibleBlocks(called on the main actor viacompleteRunCleanupwhen a run finishes) hangs the UI for over 3 seconds parsing multi-megabytefile_readtool payloads viaToolEnvelope.successPayload.Changes
file_readpayload parsing: InContentBlock.knownFileContents, guardresult.utf8.count <= knownFileParseByteLimit(1 MB) before invokingToolEnvelope.successPayload. The index only retains the first 256 KB of text per file anyway, so parsing multi-megabyte JSON payloads on the main actor was wasteful and caused UI hangs.ContentBlock.generateBlocks, build the known-files index lazily at most once per rebuild instead of re-evaluating it for every failed or streaming file edit.FileDiff.inferredEditPath, makeknownFilesan@autoclosureso the index is only evaluated when the streamingold_stringexcerpt is actually long enough (≥24 chars) to disambiguate a path.FileDiffStreamingPreviewTestsand size-cap filtering inFileReadImageAndFormatContractTests.Test Plan
Regression tests were added in
FileDiffStreamingPreviewTests(deferral of known-files evaluation) andFileReadImageAndFormatContractTests(size-cap filtering).Checklist
CONTRIBUTING.mdFixes APPLE-MACOS-3VR
@sentry <feedback>: Autofix iterates on these changes@sentry stop iterating: Autofix stops iterating on this runThis PR was automatically generated by Sentry at no cost. You can adjust this setting at any time.