Repository navigation
Delivery/esp32s3 framework bt 20260905 - #592
bigcat-2026 wants to merge 8 commits into
Conversation
0cc96ad to
7b2cf70
Compare
Signed-off-by: bigcat2026 <bigcat_2026@163.com>
7b2cf70 to
0505285
Compare
|
This PR is ready for review. Could you help take a look when you have time? |
| } | ||
|
|
||
| bt_status_t BTSYMBOLS(bt_adapter_set_debug_mode)(bt_instance_t* ins, uint8_t mode, uint8_t operation) | ||
| bt_status_t BTSYMBOLS(bt_adapter_set_debug_mode)(bt_instance_t* ins, bt_debug_mode_t mode, uint8_t operation) |
There was a problem hiding this comment.
do not touch api bt_debug_mode_t which would be confuse in android -> vela core call
|
|
||
| bt_status_t BTSYMBOLS(bt_adapter_le_add_whitelist_with_type)(bt_instance_t* ins, bt_address_t* addr, ble_addr_type_t type) | ||
| { | ||
| return adapter_le_add_whitelist_with_type(addr, type); |
There was a problem hiding this comment.
why add withlist with ble_addr_type_t?
| #define SCAN_MODE_BALANCED_WINDOW 0x140 | ||
| #define SCAN_MODE_LOW_LATENCY_INTERVAL 0xA0 | ||
| #define SCAN_MODE_LOW_LATENCY_WINDOW 0xA0 | ||
| #define SCAN_MODE_LOW_LATENCY_WINDOW 0x50 |
There was a problem hiding this comment.
why change to 0x50? it nedd full cost fot LOW_LATENCY mode
| ret = property_set_binary(key, data, length, true); | ||
| if (ret < 0) { | ||
| BT_LOGE("key %s set error!", key); | ||
| syslog(LOG_ERR, "BT storage set key failed: %s ret:%d", key, ret); |
There was a problem hiding this comment.
remove all syslog with BT_LOG*
There was a problem hiding this comment.
Copilot was unable to review this pull request because the user who requested the review has insufficient remaining quota. Try requesting a review at a lower effort level.
An organization owner can choose the repository organization as the billing source for reviews requested by members with a paid Copilot license. Learn about Copilot code review billing.
Note: Please adhere to Contributing Guidelines.
Summary
Update this section with information on why change is necessary,
what it exactly does and how, if new feature shows up, provide
references (dependencies, similar problems and solutions), etc.
Impact
Update this section, where applicable, on how change affects users,
build process, hardware, documentation, security, compatibility, etc.
Testing
Update this section with details on how did you verify the change,
what Host was used for build (OS, CPU, compiler, ..), what Target was
used for verification (arch, board:config, ..), etc. Providing build
and runtime logs from before and after change is highly appreciated.
depends-on: [open-vela/external/pull/51 open-vela/external_zblue/pull/232]