Repository navigation
Pause the menu under a script dialog - #352
Open
NedFlanders1976 wants to merge 1 commit into
Open
NedFlanders1976 wants to merge 1 commit into
NedFlanders1976 wants to merge 1 commit into
Conversation
`createDialog` keeps the dialog in `World::_userDlg` next to the menu rather than as its child, and the main menu lets the world simulate, so `World::Simulate` ran both and they polled the same mouse. A click on a dialog button over MISSION EDITOR also opened the island selection, and keys the dialog did not use reached the menu. The menu now pauses until the dialog closes, as with a child display. A cutscene under such a dialog cannot be skipped, and it ends only after the dialog closes.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
createDialogkeeps the dialog inWorld::_userDlgnext to the menu rather than as its child, and the main menu lets the world simulate, soWorld::Simulateran both and they polled the same mouse. A click on a dialog button over MISSION EDITOR also opened the island selection, and keys the dialog did not use reached the menu. The menu now pauses until the dialog closes, as with a child display. A cutscene under such a dialog cannot be skipped, and it ends only after the dialog closes.