Skip to content

Pause the menu under a script dialog - #352

Open
NedFlanders1976 wants to merge 1 commit into
ofpisnotdead-com:mainfrom
NedFlanders1976:fix/menu-under-script-dialog
Open

NedFlanders1976 wants to merge 1 commit into
ofpisnotdead-com:mainfrom
NedFlanders1976:fix/menu-under-script-dialog

Conversation

@NedFlanders1976

Copy link
Copy Markdown

createDialog keeps the dialog in World::_userDlg next to the menu rather than as its child, and the main menu lets the world simulate, so World::Simulate ran both and they polled the same mouse. A click on a dialog button over MISSION EDITOR also opened the island selection, and keys the dialog did not use reached the menu. The menu now pauses until the dialog closes, as with a child display. A cutscene under such a dialog cannot be skipped, and it ends only after the dialog closes.

  • missions are unchanged
  • found while adding a settings button to ECP's main menu

`createDialog` keeps the dialog in `World::_userDlg` next to the menu
rather than as its child, and the main menu lets the world simulate, so
`World::Simulate` ran both and they polled the same mouse. A click on a
dialog button over MISSION EDITOR also opened the island selection, and
keys the dialog did not use reached the menu. The menu now pauses until
the dialog closes, as with a child display. A cutscene under such a
dialog cannot be skipped, and it ends only after the dialog closes.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant