Skip to content

Sync to EF 11.0.0 - #4125

Merged
roji merged 1 commit into
mainfrom
roji-ef11-provider-gaps
Nov 11, 2026
Merged

roji merged 1 commit into
mainfrom
roji-ef11-provider-gaps

Conversation

@roji

@roji roji commented Nov 11, 2026

Copy link
Copy Markdown
Member

Changes

  • Update EF Core and Microsoft.Extensions dependencies to released 11.0.0, use the released .NET 11 SDK, and switch EF package dependencies to the supported [11.0.0,12.0.0) range.
  • Remove the RC-era JSON-index annotation workaround and consume EF's per-element sort directions. Replace failure-expecting tests with successful migration scaffolding/compilation and mixed-direction coverage.
  • Remove the duplicate provider NULLIF translation now that EF 11 includes the nullability correction; add SQL assertions for the upstream regressions.
  • Convert fixed complex-JSON FromSql and navigation ExecuteUpdate cases to positive tests, add the new GroupBy/Distinct DefaultIfEmpty overrides, and update TPC complex-property column-name baselines.

Upstream PRs requiring provider adjustments

Validation

Build and all three provider packages succeed. Full CI-enabled unit and functional suites against isolated PostgreSQL 18.4 with PostGIS 3.6.3: 29,868 passed, 227 skipped, 1 failed.

The sole failure, TPCInheritanceQueryNpgsqlTest.Can_insert_update_delete, expects generated key 4 in its SQL baseline but receives 3. The identical failure was reproduced independently against unchanged RC3 source at fc542f2, so it is left untouched. All upgrade-related tests pass.

Co-authored-by: Copilot App <223556219+Copilot@users.noreply.github.com>
Copilot-Session: f1ccfb3b-c59d-49f5-875c-3b2cc049752f
Copilot AI balanced review requested due to automatic review settings November 11, 2026 09:55

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🟢 Approval recommended

The review records no active issues with the EF Core 11 and .NET 11 update.

No open issues 🎉

What changed in this PR

Updates the Npgsql EF Core provider to released EF Core 11.0.0 and .NET 11, adopting upstream fixes and removing obsolete provider workarounds.

Changes:

  • Updates SDK, package versions, and EF dependency ranges for the stable release.
  • Uses upstream JSON-index metadata and per-element sort directions, and removes duplicate NULLIF translation.
  • Adds positive regression tests and SQL assertions, and updates complex-property column-name baselines.
File Description
test/​EFCore.PG.Tests/​Migrations/​JsonIndexTest.cs Tests successful migration compilation, snapshot round-trips, and mixed index directions.
test/​EFCore.PG.FunctionalTests/​Query/​Translations/​Operators/​MiscellaneousOperatorTranslationsNpgsqlTest.cs Adds NULLIF regression SQL assertions.
test/​EFCore.PG.FunctionalTests/​Query/​NorthwindGroupByQueryNpgsqlTest.cs Adds GroupBy/Distinct with DefaultIfEmpty SQL assertions.
test/​EFCore.PG.FunctionalTests/​Query/​Inheritance/​TPCInheritanceTableSplittingQueryNpgsqlTest.cs Updates inherited and nested complex-property column baselines.
test/​EFCore.PG.FunctionalTests/​Query/​Inheritance/​TPCInheritanceQueryNpgsqlTest.cs Updates TPC complex-property column baselines.
test/​EFCore.PG.FunctionalTests/​Query/​ComplexTypeQueryNpgsqlTest.cs Updates base complex-property column prefixes for TPC.
test/​EFCore.PG.FunctionalTests/​Query/​Associations/​Navigations/​NavigationsBulkUpdateNpgsqlTest.cs Replaces fixed ExecuteUpdate failure expectations with SQL assertions.
test/​EFCore.PG.FunctionalTests/​Query/​Associations/​ComplexJson/​ComplexJsonMiscellaneousNpgsqlTest.cs Tests successful FromSql queries over JSON complex properties.
test/​EFCore.PG.FunctionalTests/​Migrations/​NpgsqlMigrationsSqlGeneratorTest.cs Moves JSON-index sort configuration into model metadata.
src/​EFCore.PG/​Query/​Internal/​NpgsqlSqlTranslatingExpressionVisitor.cs Removes the provider’s duplicate NULLIF translation.
src/​EFCore.PG/​Migrations/​NpgsqlMigrationsSqlGenerator.cs Reads per-element JSON-index sort directions.
src/​EFCore.PG/​Metadata/​Internal/​NpgsqlAnnotationProvider.cs Removes the RC-era JSON-index annotation exclusion.
global.json Selects the released .NET 11 SDK.
Directory.Packages.props Updates dependencies and allows EF 11 releases below 12.0.0.
Directory.Build.props Sets the provider version prefix to 11.0.0.

Review effort: Balanced

@roji
roji enabled auto-merge (squash) November 11, 2026 10:01
@roji
roji merged commit 110cc71 into main Nov 11, 2026
16 checks passed
@roji
roji deleted the roji-ef11-provider-gaps branch November 11, 2026 10:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants