Skip to content

src: make crypto backend checks explicit - #67056

Open
panva wants to merge 1 commit into
nodejs:mainfrom
panva:crypto-backend-guards
Open

src: make crypto backend checks explicit#67056
panva wants to merge 1 commit into
nodejs:mainfrom
panva:crypto-backend-guards

Conversation

@panva

@panva panva commented Oct 27, 2026

Copy link
Copy Markdown
Member

Reject unsupported backends at compile time so OpenSSL 1.1.1 backports cannot silently use a BoringSSL or provider-specific path.

@panva
src: make crypto backend checks explicit
6efa3e1 
Reject unsupported backends at compile time so OpenSSL 1.1.1 backports
cannot silently use a BoringSSL or provider-specific path.

Signed-off-by: Filip Skokan <panva.ip@gmail.com>
@panva panva added dont-land-on-v22.x PRs that should not land on the v22.x-staging branch and should not be released in v22.x. dont-land-on-v24.x PRs that should not land on the v24.x-staging branch and should not be released in v24.x. dont-land-on-v26.x PRs that should not land on the v26.x-staging branch and should not be released in v26.x. labels Oct 27, 2026
@nodejs-github-bot

nodejs-github-bot commented Oct 27, 2026

Copy link
Copy Markdown
Collaborator

Review requested:

  • @nodejs/crypto
  • @nodejs/security-wg

@nodejs-github-bot nodejs-github-bot added c++ Issues and PRs that require attention from people who are familiar with C++. crypto Issues and PRs related to the crypto subsystem. dependencies PRs that add, update, or configure Node.js dependencies. needs-ci PRs that need a full CI run. labels Oct 27, 2026
@panva
panva requested review from aduh95, jasnell and pimterry October 27, 2026 13:07
@panva panva added author ready PRs with CI started, the required approvals, and no outstanding review comments. request-ci Add this label to start a Jenkins CI on a PR. Only starts once the PR has an approving review. labels Oct 27, 2026
@github-actions github-actions Bot removed the request-ci Add this label to start a Jenkins CI on a PR. Only starts once the PR has an approving review. label Oct 27, 2026
@nodejs-github-bot

nodejs-github-bot commented Oct 27, 2026

Copy link
Copy Markdown
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/78684/

@codecov

codecov Bot commented Oct 27, 2026 •
edited
Loading

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 90.65%. Comparing base (98dbf60) to head (6efa3e1).
⚠️ Report is 3 commits behind head on main.

Additional details and impacted files 
@@           Coverage Diff           @@
##             main   #67056   +/-   ##
=======================================
  Coverage   90.65%   90.65%           
=======================================
  Files         797      797           
  Lines      278268   278268           
  Branches    53517    53512    -5     
=======================================
+ Hits       252261   252275   +14     
- Misses      16386    16387    +1     
+ Partials     9621     9606   -15
Files with missing lines Coverage Δ
src/crypto/crypto_context.cc 75.19% <ø> (ø)
src/crypto/crypto_context.h 100.00% <ø> (ø)
src/crypto/crypto_hash.cc 78.89% <ø> (ø)
src/crypto/crypto_rsa.cc 64.26% <ø> (ø)
src/crypto/crypto_tls.cc 78.40% <ø> (ø)
src/crypto/crypto_util.cc 53.59% <ø> (+0.14%) ⬆️

... and 24 files with indirect coverage changes

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@panva panva added the commit-queue PRs queued for automated landing through the Commit Queue. label Oct 27, 2026
This was referenced Oct 28, 2026
Open
Open
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@pimterry pimterry pimterry approved these changes
@richardlau richardlau richardlau approved these changes
@jasnell jasnell Awaiting requested review from jasnell
@aduh95 aduh95 Awaiting requested review from aduh95

Assignees

No one assigned

Labels

author ready PRs with CI started, the required approvals, and no outstanding review comments. c++ Issues and PRs that require attention from people who are familiar with C++. commit-queue PRs queued for automated landing through the Commit Queue. crypto Issues and PRs related to the crypto subsystem. dependencies PRs that add, update, or configure Node.js dependencies. dont-land-on-v22.x PRs that should not land on the v22.x-staging branch and should not be released in v22.x. dont-land-on-v24.x PRs that should not land on the v24.x-staging branch and should not be released in v24.x. dont-land-on-v26.x PRs that should not land on the v26.x-staging branch and should not be released in v26.x. needs-ci PRs that need a full CI run.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@panva @nodejs-github-bot @pimterry @richardlau