Repository navigation
chore: drop unused legacy hooks that already have a typed event - #66234
Merged
Merged
Conversation
Nothing listens to `OC_Filesystem::update` or `post_update` anymore. `write`/`post_write` are emitted at the same places and typed listeners use `BeforeNodeWrittenEvent`/`NodeWrittenEvent`. Assisted-by: ClaudeCode:claude-opus-5-5 Signed-off-by: Ferdinand Thiessen <opensource@fthiessen.de>
Nothing listens to `OC_Filesystem::create_mount` or `delete_mount` anymore, `StorageCreatedEvent`, `StorageUpdatedEvent` and `StorageDeletedEvent` are dispatched instead. The mount cache invalidation that was dispatched together with the hooks is kept. Assisted-by: ClaudeCode:claude-opus-5-5 Signed-off-by: Ferdinand Thiessen <opensource@fthiessen.de>
Nothing listens to the `OCP\Share` hooks `pre_shared`, `post_shared`, `pre_unshare`, `post_unshare` and `post_unshareFromSelf` anymore. They were only re-emitted from the typed `BeforeShareCreatedEvent`, `ShareCreatedEvent`, `BeforeShareDeletedEvent`, `ShareDeletedEvent` and `ShareDeletedFromSelfEvent`, which remain. Assisted-by: ClaudeCode:claude-opus-5-5 Signed-off-by: Ferdinand Thiessen <opensource@fthiessen.de>
Nothing listens to the `Scanner::addToCache` and `removeFromCache` legacy hooks or to the `postScanFile` and `postScanFolder` signals of `OC\Files\Utils\Scanner` anymore. The cache dispatches `CacheEntryInsertedEvent`, `CacheEntryUpdatedEvent` and `CacheEntryRemovedEvent`, and the scanner dispatches `FileScannedEvent` and `FolderScannedEvent`. Assisted-by: ClaudeCode:claude-opus-5-5 Signed-off-by: Ferdinand Thiessen <opensource@fthiessen.de>
Only `postWrite` of the `\OC\Files` root folder emitter is still listened to. All other signals have typed `Node*` event replacements and no listeners left, so they are no longer emitted. Assisted-by: ClaudeCode:claude-opus-5-5 Signed-off-by: Ferdinand Thiessen <opensource@fthiessen.de>
Nothing listens to the `\OC\Group` signals `postAddUser`, `postRemoveUser`, `postDelete`, `preCreate` and `postCreate` or to the `\OC\User` signal `postRememberedLogin` anymore. `UserAddedEvent`, `UserRemovedEvent`, `GroupDeletedEvent`, `BeforeGroupCreatedEvent`, `GroupCreatedEvent` and `UserLoggedInWithCookieEvent` are dispatched at the same places. Assisted-by: ClaudeCode:claude-opus-5-5 Signed-off-by: Ferdinand Thiessen <opensource@fthiessen.de>
susnux
added
3. to review
susnux
added
the
pending documentation
susnux
marked this pull request as ready for review
November 4, 2026 11:08
susnux
requested review from
CarlSchwan,
GhassenKefi,
come-nc,
icewind1991,
marcoambrosini,
pabzm,
pringelmann,
provokateurin and
salmart-dev
and removed request for
a team,
icewind1991 and
salmart-dev
November 4, 2026 11:08
CarlSchwan
approved these changes
Nov 4, 2026
pringelmann
approved these changes
Nov 4, 2026
Merged
4 tasks done
Contributor
Author
|
documentation: nextcloud/documentation#16008 |
susnux
removed
the
pending documentation
tflidd
pushed a commit
to MrRinkana/documentation
that referenced
this pull request
Nov 7, 2026
Document the share, group, filesystem, root folder and scanner hooks removed in nextcloud/server#66234 together with their replacement events in the Nextcloud 36 developer release notes. Assisted-by: ClaudeCode:claude-opus-5-5 Signed-off-by: Ferdinand Thiessen <opensource@fthiessen.de>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
For this hooks I looked up all of our apps and non is using them anymore.
Moreover only hooks are removed that already have a typed event available.
Checklist
3. to review, feature component)stable32)AI (if applicable)