Repository navigation
Conversation
Berthe01
requested review from
ChristophWurst,
GretaD and
kesselb
as code owners
November 9, 2026 13:04
|
Thanks for opening your first pull request in this repository! ✌️ |
Contributor
|
Thanks for your contribution! Two small things:
|
Table based layouts, such as email signatures generated by signature management tools, depend on presentational attributes (cellpadding, cellspacing, width, valign...) and on inline styles of table elements. The GeneralHtmlSupport allow list only listed the table element names, so all their attributes and styles were dropped and the layout was lost on send: cell spacing, column widths, alignment and borders. Allow on table, tbody, thead, tfoot, tr, td and th the presentational attributes width, height, align, valign, bgcolor, border, cellpadding, cellspacing, colspan and rowspan, and inline styles, as already done for a and img. Event handlers stay disallowed. Assisted-by: Claude Code:claude-opus-5-5 Signed-off-by: Berthe01 <one.eloka@gmail.com>
Berthe01
force-pushed
the
fix/composer-keep-table-layout
branch
from
November 9, 2026 19:09
5b965c4 to
e51400b
Compare
Author
|
Thanks kesselb ! Done: the comment is removed, its explanation is now in the commit message, and the commit carries the Assisted-by: Claude Code:claude-opus-5-5 trailer. Regards, |
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
🤖 AI (if applicable)
``
Title
fix(composer): keep layout attributes and styles of tables
Description
Problem
HTML signatures generated by signature management tools (Signitic, Exclaimer, CodeTwo…) and
many pasted contents use table-based layouts. Since tables are supported by the composer
(GeneralHtmlSupport allow list), the table elements survive, but every attribute and inline
style of
table,tr,td… is dropped, because the allow list only lists their names.As a result, a message sent from Mail loses the layout of the signature:
cellspacing="0"/cellpadding="0"are dropped, so recipients' clients apply their defaultcell spacing at every nesting level (visible gaps);
width), heights and vertical alignment (valign,vertical-align) are lost;border-leftbetween a logo and contactdetails) disappear.
Measured on a real generated signature (4 nested tables, 14 cells): the signature stored in Mail
contains 14 cells with styles/attributes; the sent message contains the 14 cells with none of
them (0
style, 0width/valign). Text, images, links and colours are kept.Change
Allow, on
table,tbody,thead,tfoot,tr,tdandth:width,height,align,valign,bgcolor,border,cellpadding,cellspacing,colspan,rowspan;styles: true), as already done foraandimg.Security considerations
on*) stay disallowed(covered by the new test).
aandimg; this extends the same rule to tableelements. GeneralHtmlSupport keeps filtering what it does not know.
Tests
mode; layout attributes and styles are preserved,
onclickis not.message (before: no attribute/style on cells; after: preserved).
Verified locally (node 24, 2026-11-09): the new test fails on
mainand passes with the change;the whole unit suite passes (68 files, 555 tests); no new ESLint warning (the only warning in
TextEditor.spec.js, an unusedwrapperin "shallow mounts", already exists onmain).Note for reviewers:
GeneralHtmlSupportloads widget plugins that expecteditor.ui.focusTracker,which
VirtualTestEditordoes not provide; the test adds a minimal UI stub for that reason.``