Repository navigation
Conversation
This was referenced Oct 16, 2026
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
An application callback that returns fewer frames than requested must remain drained across a device change, even when buffered resampler output fills the current device buffer. Keep the terminal callback result on the stream in AAudio, WASAPI and C++ AudioUnit so replacing the resampler cannot resume application callbacks.
AAudio recovery now completes an existing drain without restarting the replacement device or emitting STARTED, preserves callback errors, and resets both the resampler and position bookkeeping on an explicit restart. C++ AudioUnit also resets its drained resampler on explicit start.
Validation: 42 AAudio cases pass with host AAudio stubs; all 20 native macOS resampler tests pass. Added tests cover short and zero returns, resampler buffering, repeated recovery, explicit restart, delayed callbacks, and callback versus device-stop errors. Windows validation is left to CI.
This addresses the cubeb behavior behind https://phabricator.services.mozilla.com/D334378. Buffered audio on the removed device may be lost.
Related Rust fixes: mozilla/cubeb-coreaudio-rs#293 and mozilla/cubeb-pulse-rs#117.