Repository navigation
Conversation
bendk
requested review from
a team,
freshstrangemusic,
justindarc,
mhammond and
ncloudioj
and removed request for
a team
October 23, 2026 20:44
Contributor
Author
|
I added a reviewer for each team this affects. I'm guessing this is not too controversial, tell me if you have any concerns. If I don't hear back by the middle of next week, I'll probably assume that you don't mind one way or the other and go ahead and merge it. |
bendk
commented
Oct 23, 2026
| pub use crate::stateful::matcher::AppContext; | ||
| pub use crate::stateful::nimbus_client::*; | ||
| pub use crate::stateful::targeting::*; | ||
| pub use crate::stateful::firefox_labs::*; |
Contributor
Author
There was a problem hiding this comment.
Maybe I could have been more selective with the imports here, tell me if you'd prefer that I only import specific items.
bendk
force-pushed
the
bdk/push-pnnuwlrnluoq
branch
from
October 23, 2026 20:52
0821b9c to
bfc31d2
Compare
Make all items exposed by UniFFI `pub`. In practice this probably makes no difference, because these crates aren't consumed by other Rust crates. If they do get added as dependencies, this feels more correct to me. If we're exposing them to the foreign side, we should also expose them to Rust.
bendk
force-pushed
the
bdk/push-pnnuwlrnluoq
branch
from
October 26, 2026 13:39
bfc31d2 to
a17ad26
Compare
mhammond
approved these changes
Oct 26, 2026
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Make all items exposed by UniFFI
pub. In practice this probably makes no difference, because these crates aren't consumed by other Rust crates. If they do get added as dependencies, this feels more correct to me. If we're exposing them to the foreign side, we should also expose them to Rust.Pull Request checklist
[ci full]to the PR title.