Repository navigation
Conversation
The moby-integration job only ran the extension integration tests, which manage their own daemons. A dockerd that failed to start with its default settings could go unnoticed. Signed-off-by: Paweł Gronowski <git@grono.dev>
There was a problem hiding this comment.
🟢 Approval recommended
The focused CI change checks daemon startup with failure reporting and cleanup, and no blocking issues were identified.
No open issues 🎉
What changed in this PR
Adds a daemon startup smoke check to the Moby integration job, covering startup failures that extension integration tests could miss because they manage their own daemons.
Changes:
- Builds and starts the Moby daemon inside the development container.
- Polls for readiness and checks
docker versionanddocker info. - Cleans up the daemon and prints its logs on failure.
| File | Description |
|---|---|
.github/workflows/ci.yml |
Adds the daemon startup check before extension integration tests. |
Review effort: Balanced
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The moby-integration job only ran the extension integration tests, which manage their own daemons.
A dockerd that failed to start with its default settings could go unnoticed.