Repository navigation
[29.0] Consistent Error Posting GST Distribution Reversal - #13097
Open
Shikhverma wants to merge 1 commit into
Open
Shikhverma wants to merge 1 commit into
Shikhverma wants to merge 1 commit into
Conversation
This branch was successfully deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Bug 654810: [BC-IN] Online: Consistent Error Posting GST Distribution Reversal
Fixes AB#654810
Issue : Posting a GST Distribution Reversal fails with an error when the distributed GST amounts have decimals.
reversals with whole amounts post correctly.
Root Cause : GST amounts are rounded per component line during distribution. A rounding difference is applied for normal distributions (to Debit amount), but not on reversals. On a reversal, the total credit amount of the component lines differs from the original GST amount by the rounding difference (eg. 0.01) so the document doesn't balance.
Solution : For reversals, Calculate the difference between the reversed GST amount and the total Credit Amount, and add it to the credit amount of the first matching component line. This mirrors the existing rounding logic for normal distributions, which is unchanged