Repository navigation
ci(dependabot): ignore ESM-only majors of p-cancelable and p-retry - #314
Merged
Merged
Conversation
p-cancelable >=3 and p-retry >=5 are pure ESM, and this package is CommonJS. Ignoring their major updates in config keeps the rule in the repo (not only in Dependabot's per-PR state, as with #312 and #313), while patch and minor updates within the current majors still arrive. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
|
Caution Review failedThe pull request is closed.
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. |
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=60&v=4){kind=small}
There was a problem hiding this comment.
html-get
Details
| Benchmark suite | Current: d6b2229 | Previous: db53aa2 | Ratio |
|---|---|---|---|
html rewriteUrls off |
124.8 ms (119.7-130.6) |
126.1 ms (116.8-135.7) |
0.99 |
html rewriteUrls on |
189.3 ms (184.8-194.1) |
192.4 ms (187.8-196.9) |
0.98 |
pdf extract |
76.8 ms (73.7-86.1) |
76.6 ms (73.8-83.6) |
1.00 |
cold require |
185.5 ms (180.1-201.2) |
190.7 ms (186.8-201.8) |
0.97 |
This comment was automatically generated by workflow using github-action-benchmark.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What changed
.github/dependabot.yml: the npm updater now ignores major updates forp-cancelableandp-retry.Why
Both packages are ESM-only from their next major (
p-cancelable3+,p-retry5+), and html-get is CommonJS. The@dependabot ignore this dependencycomments on #312 and #313 only live in Dependabot's own state. This puts the rule in the repo, where it can be reviewed and changed.Only majors are ignored, so patch and minor updates within
p-cancelable@2andp-retry@4still come through.How it was tested
yaml@2.5.1(valid+--json): theignorelist sits under the npm entry, and the github-actions entry is unchanged.ignore[].dependency-name+update-typesschema, the same shape the github-actions entry already uses.Outcome
Dependabot stops opening breaking ESM major bumps for these two packages (like #312 and #313).
🤖 Generated with Claude Code
Note
Low Risk
Only Dependabot configuration changes; no runtime code paths are affected. Risk is low aside from possibly missing future major security fixes for those packages unless handled manually.
Overview
Dependabot is now configured to skip semver-major updates for
p-cancelableandp-retryunder the npm updater, while still allowing minor/patch bumps within the current major lines.This codifies the ignore rules in
.github/dependabot.yml(rather than only in Dependabot’s own state) to avoid ESM-only majors that are incompatible with the project’s CommonJS setup. The github-actions updater block is unchanged.Reviewed by Cursor Bugbot for commit d6b2229. Bugbot is set up for automated code reviews on this repo. Configure here.