Repository navigation
Conversation
The SQS maker with an icet-* sqs_method built jobs without error and only raised ImportError on the worker. icet is now the sqs extra, the maker checks for it at construction, and CI installs it so test_sqs runs.
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Running the SQS job requires external software, one option of which is
icetwhich ispipinstallable. This should be included as an optional dependency/extra in atomate2, otherwise the job will only fail at runtime if it is not installed.Warning
below text authored by claude, not human ardunn
Problem
An
SQSmaker with anicet-*sqs_methodbuilds andmake()s a job with no error. If icet isn't installed, the job only fails once it runs on the worker, withImportError: IcetSQS requires the icet packagefrompymatgen.io.icet. atomate2 never declares icet as a dependency, sotest_sqsis also always skipped in CI.Changes (7 lines)
pyproject.toml: newsqs = ["icet>=3.0"]extra.SQS.__post_init__: raisesImportError("pip install atomate2[sqs] to use icet SQS methods")when the maker is constructed with anicet-*method and icet is missing.mcsqsmakers are unaffected.testing.yml: the non-forcefield test job installssqs, sotest_sqsruns instead of being skipped.Testing
tests/common/jobs/test_transform.pypasses with icet 4.0 and with icet 3.0 (the floor).mcsqsmaker still constructs.Not addressed here
SQS()with no arguments raisesTypeError: 'SQSTransformation' object is not callable:default_factoryis given an instance instead of a callable.mcsqsmethod still fails only at runtime if the ATATmcsqsbinary isn't onPATH. It isn't pip-installable, so an extra doesn't help there.