Repository navigation
Conversation
Add a converged field to the aims Calculation and AimsTaskDoc schemas and mark calculations that did not converge as FAILED, as done for VASP. The completed field keeps its meaning (the run produced results). Co-Authored-By: Claude Sonnet 5.5 <noreply@anthropic.com>
Co-Authored-By: Claude Sonnet 5.5 <noreply@anthropic.com>
Contributor
Author
|
The failure of the phonon test seems to be directly related to the one pointed out here #1474 (comment) |
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
FHI-aims runs that finished without converging were marked
SUCCESS, because completed only means the run produced output, and their child jobs kept running.This PR adds a converged field to the aims
CalculationandAimsTaskDoc, read fromAimsOutput.converged, and marks a completed runFAILEDonly when converged isFalse.should_stop_childrenandhandle_unsuccessfulthen handle unconverged runs as they do for VASP, wherehas_vasp_completedcomes fromvasprun.converged. When convergence is unknown (i.e.,AimsOutput.convergedis not available in the used version of `pymatgen-io-aims), behaviour is unchanged.Additional dependencies introduced (if any)
No new dependencies. However, the feature only takes effect with a
pymatgen-io-aimsrelease that providesAimsOutput.converged, which is currently not available on PyPi. Older versions still work, becauseconvergedstaysNoneand behaviour is unchanged. The aims extra inpyproject.toml(pymatgen-io-aims>=0.0.5) should be bumped to that release once it is out.TODO (if any)
pymatgen-io-aimsminimum version inpyproject.tomlonce the release withAimsOutput.convergedexists.Checklist
ruffandruff format0.16.5, the pre-commit pin, are clean on the changed files)ruffis clean)