Skip to content

Use FHI-aims convergence status to set calculation and task state - #1648

Open
akwarii wants to merge 6 commits into
materialsproject:mainfrom
akwarii:aims-converge
Open

akwarii wants to merge 6 commits into
materialsproject:mainfrom
akwarii:aims-converge

Conversation

@akwarii

@akwarii akwarii commented Nov 10, 2026

Copy link
Copy Markdown
Contributor

Summary

FHI-aims runs that finished without converging were marked SUCCESS, because completed only means the run produced output, and their child jobs kept running.

This PR adds a converged field to the aims Calculation and AimsTaskDoc, read from AimsOutput.converged, and marks a completed run FAILED only when converged is False. should_stop_children and handle_unsuccessful then handle unconverged runs as they do for VASP, where has_vasp_completed comes from vasprun.converged. When convergence is unknown (i.e., AimsOutput.converged is not available in the used version of `pymatgen-io-aims), behaviour is unchanged.

Additional dependencies introduced (if any)

No new dependencies. However, the feature only takes effect with a pymatgen-io-aims release that provides AimsOutput.converged, which is currently not available on PyPi. Older versions still work, because converged stays None and behaviour is unchanged. The aims extra in pyproject.toml (pymatgen-io-aims>=0.0.5) should be bumped to that release once it is out.

TODO (if any)

  • Bump the pymatgen-io-aims minimum version in pyproject.toml once the release with AimsOutput.converged exists.

Checklist

akwarii and others added 5 commits October 8, 2026 17:47
Add a converged field to the aims Calculation and AimsTaskDoc schemas and
mark calculations that did not converge as FAILED, as done for VASP. The
completed field keeps its meaning (the run produced results).

Co-Authored-By: Claude Sonnet 5.5 <noreply@anthropic.com>
Co-Authored-By: Claude Sonnet 5.5 <noreply@anthropic.com>
@akwarii

akwarii commented Nov 10, 2026

Copy link
Copy Markdown
Contributor Author

The failure of the phonon test seems to be directly related to the one pointed out here #1474 (comment)

This branch has not been deployed

No deployments
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant